Created attachment 383890 [details] wit-bin-2.29a.ebuild Wiimms ISO Tools is a set of command line tools to manipulate Wii and GameCube ISO images and WBFS containers. Attached ebuild has been tested on amd64.
Comment on attachment 383890 [details] wit-bin-2.29a.ebuild >EAPI=5 >inherit eutils You don't seem to use eutils.eclass here. >[ "$ARCH" == "amd64" ] && MY_ARCH=x86_64 || MY_ARCH=x86 You cannot use this for SRC_URI. The architecture neutral package management metadata generation utilities will not know how to handle this. See below... >MY_REV=5186 > >DESCRIPTION="Wiimms ISO Tools is a set of command line tools to manipulate Wii and GameCube ISO images and WBFS containers" That's slightly long. >HOMEPAGE="http://wit.wiimm.de/" >SRC_URI="http://wit.wiimm.de/download/wit-v${PV}-r${MY_REV}-${MY_ARCH}.tar.gz" ... SRC_URI=" amd64? ( ... ) x86? ( ... ) " >LICENSE="GPL-2" If it's open source, then why don't we just build from source? >SLOT="0" >KEYWORDS="amd64 ~x86 -*" Fresh ebuilds always start out with ~arch. >IUSE="" Empty IUSE shouldn't be set. >RESTRICT="strip" You should probably use QA_PREBUILT="*" here to not trip up other QA checks. >DEPEND="" No need to set an empty DEPEND. >S=${WORKDIR}/wit-v${PV}-r${MY_REV}-${MY_ARCH} Here you could use an if [[ ${ARCH} = ... ]]; then ... else ... fi (or better a case ... esac for clarity). Doing an && .. || as above causes problems when the next arch is added.
Created attachment 384144 [details] wit-bin-2.29a.ebuild (In reply to Jeroen Roovers from comment #1) Thanks for the feedback. The updated version addresses most of your suggestions, though I do have a couple questions. > >[ "$ARCH" == "amd64" ] && MY_ARCH=x86_64 || MY_ARCH=x86 > > You cannot use this for SRC_URI. The architecture neutral package management > metadata generation utilities will not know how to handle this. See below... Could you please help me understand why this is problematic? I've never had a problem generating manifests and whatnot on my system, but then again I just stick to Linux. I've had someone else mention something similar to this once before, so I'd like to understand the details here so I can deal with it appropriately in the future. > >LICENSE="GPL-2" > > If it's open source, then why don't we just build from source? As far as I can tell he doesn't release source snapshots. The binaries work perfectly on my system and I prefer to avoid doing svn/git/etc. ebuilds unless there's no other choice, so I just went with the path of least resistance.
Since I've had a source-based ebuild in one of my overlays for years I decided to throw it in the main tree for you. Have fun! :)
that's fantastic. Thanks, Tim.
