521438 – net-irc/bitchx-1.2: suspicious use of einstall

Bug 521438 - net-irc/bitchx-1.2: suspicious use of einstall

Summary: net-irc/bitchx-1.2: suspicious use of einstall

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	Packages in net-irc

URL:
Whiteboard:	suspicious-einstall
Keywords:

Depends on:
Blocks:	suspicious-einstall
	Show dependency tree

Reported:	2014-08-28 20:42 UTC by Michał Górny
Modified:	2014-08-30 04:45 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2014-08-28 20:42:17 UTC

Please check whether the use of 'einstall' in this ebuild is actually
needed. From a quick glance at the Makefile, it seems to have proper
support for DESTDIR.

Therefore, if possible please replace the call to 'einstall' with proper
'default' or 'emake DESTDIR="${D}" install'. Thanks.

Comment 1 Nathan Phillip Brink (binki) (RETIRED) gentoo-dev

2014-08-30 04:45:49 UTC

Yup, that einstall() is extraneous and installs the same things as `emake DESTDIR="${D}" install`.

+  30 Aug 2014; Nathan Phillip Brink <binki@gentoo.org> bitchx-1.2.ebuild:
+  Drop einstall() from bitchx-1.2 for bug #521438.