521434 – dev-libs/syck-0.55-r4: suspicious use of einstall

Bug 521434 - dev-libs/syck-0.55-r4: suspicious use of einstall

Summary: dev-libs/syck-0.55-r4: suspicious use of einstall

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it

URL:
Whiteboard:	suspicious-einstall
Keywords:

Depends on:
Blocks:	suspicious-einstall
	Show dependency tree

Reported:	2014-08-28 20:37 UTC by Michał Górny
Modified:	2014-12-19 09:26 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
syck-0.55-r4.ebuild.patch (syck-0.55-r4.ebuild.patch,213 bytes, patch) 2014-11-29 22:39 UTC, Patrice Clement	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2014-08-28 20:37:28 UTC

Please check whether the use of 'einstall' in this ebuild is actually
needed. From a quick glance at the Makefile, it seems to have proper
support for DESTDIR.

Therefore, if possible please replace the call to 'einstall' with proper
'default' or 'emake DESTDIR="${D}" install'. Thanks.

Comment 1 Patrice Clement gentoo-dev

2014-11-29 22:39:29 UTC

Created attachment 390614 [details, diff]
syck-0.55-r4.ebuild.patch

Hi Michal

Thanks for pointing this out. Indeed, it does work with emake. I've attached a patch with your suggestion. I'm going to revbump the ebuild for the time being.

Comment 2 Pacho Ramos gentoo-dev

2014-12-19 09:26:09 UTC

fixed in -r5

*syck-0.55-r5 (29 Nov 2014)

  29 Nov 2014; Patrice Clement <monsieurp@gentoo.org> +syck-0.55-r5.ebuild,
  syck-0.55-r4.ebuild:
  Replace einstall with emake install and revbump the ebuild. See #521434.