Please drop IUSE="bash-completion zsh-completion" and install those files unconditionally. Esp. zsh-completion? ( app-shells/zsh ) seems to be incorrect, as the ebuild is only installing a completion file.
+ 28 Aug 2014; Amadeusz Żołnowski <aidecoe@gentoo.org> notmuch-0.18.1.ebuild: + Unconditional installation of zsh/bash completion files. Fixes bug #521372. + Please check if it's OK and then I'll backport it to older, stable versions.
I don't like the dependency on the whole bash-completion-stack. Fri Aug 29 12:03:35 2014 >>> app-admin/eselect-bashcomp-1.3.6 Fri Aug 29 12:03:45 2014 >>> app-shells/bash-completion-2.1-r1 Fri Aug 29 12:03:54 2014 >>> app-shells/gentoo-bashcomp-20121024 /usr/share/bash-completion already contains a lot of completion files, without app-shells/bash-completion. So could we get rid of the dep on >=app-shells/bash-completion-1.9, please? Thx :)
notmuch requires at least version 1.9 and we have to enforce this dependency.
(In reply to Amadeusz Żołnowski from comment #3) > notmuch requires at least version 1.9 and we have to enforce this dependency. Force a dependency on an OPTIONAL feature? Other packages use pkg_postinst to make the user aware of optional features that will be available after installing certain additional packages. Just mention that for notmuch you need at least bash-completion-1.9. I see that bash-completion is a widely used feature and users probably expect it to work. Nevertheless the user will notice when completion does not work and (hopefully) find the message from notmuch he just missed. But in the end I don't REALLY care about those something-dozen files that I have on my disk additionally ;)
Done in stable ebuild as well. + 01 Sep 2014; Amadeusz Żołnowski <aidecoe@gentoo.org> + notmuch-0.16-r1.ebuild, notmuch-0.17.ebuild: + Install zsh and bash completion files unconditionally. +
(In reply to Franz Fellner from comment #4) > (In reply to Amadeusz Żołnowski from comment #3) > > notmuch requires at least version 1.9 and we have to enforce this dependency. > > Force a dependency on an OPTIONAL feature? I expect the reason for dropping the USE-based dependencies is this policy [1]: > The usage of a USE flag should not control runtime dependencies when the > package does not link to it. Doing so will create extra configuration for > the package and re-compilation for no underlying file change on disk. This > should be avoided and instead can be conveyed to the user via post install > messages if needed. While the changes made because of the issue comply with the letter of that policy, I join Franz and the devmanual authors in prefering the pkg_postinst route to forcing the dependency. [1]: http://devmanual.gentoo.org/general-concepts/use-flags/
