Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 519772 - =dev-libs/protobuf-c-0.15 keyword request
Summary: =dev-libs/protobuf-c-0.15 keyword request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Low enhancement (vote)
Assignee: Maciej Mrozowski
URL:
Whiteboard:
Keywords: KEYWORDREQ, PullRequest
Depends on: 519812
Blocks: 519854 531068
  Show dependency tree
 
Reported: 2014-08-13 02:05 UTC by Maciej Mrozowski
Modified: 2020-02-03 15:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Mrozowski gentoo-dev 2014-08-13 02:05:23 UTC
net-libs/libgadu-1.12.0 introduces GaduGadu 11 protocol support that requires protobuf.

Feel free to opt out and leave pkg. use mask alone.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-13 08:19:25 UTC
Why didn't you simply drop the keywords like you should have?

>>> Creating Manifest for /newaches/gentoo/cvs/gentoo-x86/net-libs/libgadu

RepoMan scours the neighborhood...
  dependency.bad                2
   net-libs/libgadu/libgadu-1.12.0.ebuild: DEPEND: ~hppa(default/linux/hppa/13.0) ['>=dev-libs/protobuf-c-0.15']
   net-libs/libgadu/libgadu-1.12.0.ebuild: RDEPEND: ~hppa(default/linux/hppa/13.0) ['>=dev-libs/protobuf-c-0.15']

Note: use --include-dev (-d) to check dependencies for 'dev' profiles

Oh, _and_ you broke the tree?
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-13 08:20:48 UTC
And you didn't warn arch teams that you had messed with the profiles.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-13 08:23:30 UTC
03:47:04 @<reavertm> rej: is that just you who is territorial wrt package.use.mask in profiles/arch/hppa or it's common process let ebuild maintainer "sort our repoman warnings" in arches? (or else?)

And then you turn your ineptitude into a passive/aggressive slur.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-13 08:26:58 UTC
So instead of issuing

  ekeyword ^alpha ^hppa ^ia64 ^powerpc ^sparc libgadu-1.12.0.ebuild

and then committing that and filing this KEYWORD request, changing a single file in the process, namely your ebuild, you went ahead and changed eight files in the profiles subdirectories instead.
Comment 5 Anthony Basile gentoo-dev 2014-08-13 17:38:44 UTC
keyworded ~ppc ~ppc64
Comment 6 Maciej Mrozowski gentoo-dev 2014-08-13 22:35:10 UTC
My bad. I was under impression that profiles are to be touched by ebuild maintainers in such cases.
Comment 7 Maciej Mrozowski gentoo-dev 2014-08-13 22:44:17 UTC
Apologies if that sounded passive-aggressive. You know however that I referred to:
"# DON'T TOUCH THIS FILE. Instead, file a bug and assign it to <hppa@gentoo.org>." - and this is territorialism :)
It's been a while since I revbumped package with keywords dropped.
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-13 22:57:47 UTC
(In reply to Maciej Mrozowski from comment #6)
> My bad. I was under impression that profiles are to be touched by ebuild
> maintainers in such cases.

The information you need is right here:

   "Sometimes you may need to remove a keyword because of new unresolved dependencies.
    If you do this, you must file a bug notifying the relevant arch teams."
    http://devmanual.gentoo.org/keywording/index.html
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-13 23:56:50 UTC
  13 Aug 2014; Anthony G. Basile <blueness@gentoo.org> protobuf-c-0.15.ebuild:
  Keyword ~ppc and ~ppc64, bug #519772

You forgot to keyword the newer 1.0.1 ebuild.
Comment 10 Tobias Klausmann (RETIRED) gentoo-dev 2014-11-21 09:53:31 UTC
Can someone sum up what actually needs to be keyworded now?

dev-libs/protobuf-c has a dep on dev-libs/protobuf

Neither of them are keyworded at all on Alpha, so know what is needed would be nice.
Comment 11 Alex Xu (Hello71) 2015-03-28 01:11:01 UTC
I think protobuf-c needs ~ppc ~ppc64?
Comment 12 Anthony Basile gentoo-dev 2015-04-20 16:43:00 UTC
(In reply to Alex Xu (Hello71) from comment #11)
> I think protobuf-c needs ~ppc ~ppc64?

These are masked on ppc and ppc64.  Can I get some direction here from the maintainer?  Should I be unmasking anything?  If so what?
Comment 13 Jeroen Roovers (RETIRED) gentoo-dev 2015-04-25 11:57:50 UTC
  25 Apr 2015; Jeroen Roovers <jer@gentoo.org> protobuf-c-1.1.1.ebuild:
  Marked ~ppc64 too.
Comment 14 Pacho Ramos gentoo-dev 2015-05-15 12:29:45 UTC
ppc done
Comment 15 Matt Turner gentoo-dev 2015-05-21 04:25:46 UTC
(In reply to Tobias Klausmann from comment #10)
> Can someone sum up what actually needs to be keyworded now?
> 
> dev-libs/protobuf-c has a dep on dev-libs/protobuf
> 
> Neither of them are keyworded at all on Alpha, so know what is needed would
> be nice.

Still waiting on confirmation.
Comment 16 Tobias Klausmann (RETIRED) gentoo-dev 2015-07-15 15:51:20 UTC
Since reavertm is gone and protobuf{,-c} is maintainer-needed, I just went with these for Alpha:

=dev-libs/protobuf-c-1.1.1
=dev-libs/protobuf-2.6.1-r3
=dev-python/google-apputils-0.4.2
=dev-python/python-gflags-2.0
=dev-python/mox-0.5.3-r1

Since the dependents (libgadu and unbound) have been waiting so long, I'm going to shorten the soak period in ~alpha to ten days (until July 25th) before they go stable.

The depending packages I'll handle accordingly for alpha.
Comment 17 Tobias Klausmann (RETIRED) gentoo-dev 2015-07-29 14:42:28 UTC
(In reply to Tobias Klausmann from comment #16)
> =dev-libs/protobuf-c-1.1.1
> =dev-libs/protobuf-2.6.1-r3
> =dev-python/google-apputils-0.4.2
> =dev-python/python-gflags-2.0
> =dev-python/mox-0.5.3-r1

These are now stable on alpha.
Comment 18 Pacho Ramos gentoo-dev 2015-08-02 10:08:27 UTC
sparc done
Comment 19 Agostino Sarubbo gentoo-dev 2015-11-18 10:31:12 UTC
ia64 stable. Closing.
Comment 20 Larry the Git Cow gentoo-dev 2020-02-03 15:04:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ba33f2bf790d91f820019310fae6ac18b92fc9c6

commit ba33f2bf790d91f820019310fae6ac18b92fc9c6
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-02-02 21:26:15 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-02-03 15:03:27 +0000

    profiles: alpha/hppa: Drop outdated gadu use.mask
    
    Both arches got dev-libs/protobuf-c keyworded in the end, so we'll assume
    it does build now(?).
    
    Changing to net-im/pidgin[gadu] package.use.mask instead.
    
    Bug: https://bugs.gentoo.org/519772
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/arch/alpha/package.use.mask | 5 +++++
 profiles/arch/alpha/use.mask         | 5 -----
 profiles/arch/hppa/package.use.mask  | 4 ++++
 profiles/arch/hppa/use.mask          | 4 ----
 4 files changed, 9 insertions(+), 9 deletions(-)