519294 – media-libs/giflib-5.0.6 - `myconfargs' should be `myeconfargs'

Bug 519294 - media-libs/giflib-5.0.6 - `myconfargs' should be `myeconfargs'

Summary: media-libs/giflib-5.0.6 - `myconfargs' should be `myeconfargs'

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Library (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo Graphics Project

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:	myconfargs-typo
	Show dependency tree

Reported:	2014-08-07 05:55 UTC by Casper Ti. Vector
Modified:	2014-08-07 16:37 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Casper Ti. Vector 2014-08-07 05:55:46 UTC

(Originally reported in bug #518106; now reported as separate bugs after consulting devs on #gentoo at freenode.)

As the title says.  Eclasses only provided the `myeconfargs' interface, not `myconfargs'.  Affected ebuild(s) do not seem to use `myconfargs' side by side with `myeconfargs' on purpose, so this is probably a typo.

Following is the patch:

--- /usr/portage/media-libs/giflib/giflib-5.0.6.ebuild	2014-06-10 09:31:22.000000000 +0800
+++ -	2014-08-07 13:54:21.216530082 +0800
@@ -28,7 +28,7 @@
 }
 
 src_configure() {
-	local myconfargs=(
+	local myeconfargs=(
 		$(use_enable static-libs static)
 	)
 	# No need for xmlto as they ship generated files.

Comment 1 Michał Górny archtester

2014-08-07 09:43:37 UTC

@hasufell, you seem to be responsible for this! Worse than that, the patch on bug #496548 seems fine :P.

Comment 2 Julian Ospald 2014-08-07 12:10:38 UTC

just fix it then

Comment 3 Michał Górny archtester

2014-08-07 16:37:20 UTC

+  07 Aug 2014; Michał Górny <mgorny@gentoo.org> giflib-5.0.6.ebuild:
+  Fix typo in myeconfargs. Pass ac_cv* values verbosely via command-line rather
+  than environment. Bug #519294.