Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 515094 - gnome-base/orbit-2.14.19 [Prefix]: AIX <sys/timer.h> defines 'func_data', need to rename within orbit code
Summary: gnome-base/orbit-2.14.19 [Prefix]: AIX <sys/timer.h> defines 'func_data', nee...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2014-06-25 13:32 UTC by Michael Haubenwallner (RETIRED)
Modified: 2014-07-08 07:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
rename 'func_data' for aix (orbit-2.14.19-aix-func_data.patch,2.62 KB, patch)
2014-06-25 13:32 UTC, Michael Haubenwallner (RETIRED)
Details | Diff
Patch for Prefix support (orbit-prefix.diff,649 bytes, patch)
2014-07-07 15:09 UTC, Michael Haubenwallner (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Haubenwallner (RETIRED) gentoo-dev 2014-06-25 13:32:40 UTC
Created attachment 379652 [details, diff]
rename 'func_data' for aix

Get this build error on ppc-aix:

In file included from orbit-idl-main.c:34:
orbit-idl2.h:19: error: expected ';', ',' or ')' before '.' token
orbit-idl2.h:22: error: expected ';', ',' or ')' before '.' token

Attached patch renames 'func_data' to 'gfunc_data'.

Maybe I should make an upstream report too?
Comment 1 Pacho Ramos gentoo-dev 2014-06-25 19:37:02 UTC
Yes, would be better to report to upstream too... even if I doubt that upstream will still take care as orbit is dead for ages, but maybe they will commit it :/
Comment 2 Pacho Ramos gentoo-dev 2014-07-07 13:03:42 UTC
Feel free to commit please :)
Comment 3 Michael Haubenwallner (RETIRED) gentoo-dev 2014-07-07 15:09:17 UTC
Created attachment 380368 [details, diff]
Patch for Prefix support

Ohw, just found out that there is still a copy in prefix overlay, with this diff necessary for Prefix support - please review too, thanks!
Comment 4 Pacho Ramos gentoo-dev 2014-07-07 20:16:17 UTC
Well, it looks ok to me. We are now deprecating G2CONF usage, then, maybe you could use some other variable name like "myconf" and append ${myconf} at the end of gnome2_src_configure call
Comment 5 Michael Haubenwallner (RETIRED) gentoo-dev 2014-07-08 07:18:30 UTC
Fixed in orbit-2.14.19-r4, thanks!