Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 51442 - app-crypt/johntheripper mega patch ebuild. skey is broken
Summary: app-crypt/johntheripper mega patch ebuild. skey is broken
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Daniel Black (RETIRED)
Depends on:
Blocks: 49988
  Show dependency tree
Reported: 2004-05-18 18:16 UTC by Ghislain Bourgeois
Modified: 2004-05-24 16:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Corrected NTLM patch (john-ntlm-patch-v02.tgz,8.51 KB, patch)
2004-05-18 18:23 UTC, Ghislain Bourgeois
Details | Diff
the patch needed for ntlm to build with skey (john-ntlm.skey.patch,1.14 KB, patch)
2004-05-18 18:25 UTC, Ghislain Bourgeois
Details | Diff
Patch for mysql support, corrected to apply after skey and ntlm (john-1.6-mysql.diff,8.71 KB, patch)
2004-05-18 19:21 UTC, Ghislain Bourgeois
Details | Diff
This ebuild build johntheripper with SKEY, NTLM and MYSQL support (johntheripper-contrib-1.6.ebuild,2.35 KB, text/plain)
2004-05-18 19:26 UTC, Ghislain Bourgeois
john-1.6-gentoo.patch (john-1.6-gentoo.patch,150.43 KB, patch)
2004-05-19 16:52 UTC, Daniel Black (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ghislain Bourgeois 2004-05-18 18:16:34 UTC
Started this bug to have a place to work on a new version of the ebuild for johntheripper-1.6 that will eventually have a gentoo-patchset to include all contributions to john. I suggest it becomes a package johntheripper-contrib when it is done. This way, user could emerge johntheripper if they want just the base john and johntheripper-contrib if they want it with all the contrib. Since the contrib patches are all working on the same code area, it is really difficult to take them all in our out depending on use flag.


Reproducible: Always
Steps to Reproduce:

I will post attachments as I work on this
Comment 1 Ghislain Bourgeois 2004-05-18 18:23:27 UTC
Created attachment 31694 [details, diff]
Corrected NTLM patch

I have modified the NTLM patch so that it can now compile correctly. This patch
can be use as a replacement for the official one with johntheripper-1.6-r2 and
the ntlm use flag. 

Comment 2 Ghislain Bourgeois 2004-05-18 18:25:44 UTC
Created attachment 31695 [details, diff]
the patch needed for ntlm to build with skey

This is the patch that should go in the filesdir of the ebuild to permit ntlm
patch to apply after the skey patch...

Comment 3 Ghislain Bourgeois 2004-05-18 19:21:56 UTC
Created attachment 31697 [details, diff]
Patch for mysql support, corrected to apply after skey and ntlm

With this patch, you can build johntheripper with SKEY, NTLM and MYSQL support

Comment 4 Ghislain Bourgeois 2004-05-18 19:26:00 UTC
Created attachment 31698 [details]
This ebuild build johntheripper with SKEY, NTLM and MYSQL support

This ebuild uses the files given above in FILESDIR to build johntheripper with
contribution patches for SKEY, NTLM and MYSQL. As said above, since all the
patch change the same code area, it is too difficult to get them in or out
depending on USE flags, so this ebuild is the solution for those who want the
contributions in john. 

I will work on the other contributions to get them to work.

Comment 5 Martin Holzer (RETIRED) gentoo-dev 2004-05-18 23:37:07 UTC
sorry, but are you gentoo-dev or know some who check this into portage ?
Comment 6 Ghislain Bourgeois 2004-05-19 09:17:29 UTC
Yes, I was actually working on this with dragonheart. Reassigned to him.
Comment 7 Daniel Black (RETIRED) gentoo-dev 2004-05-19 16:52:09 UTC
Created attachment 31726 [details, diff]

Grand all patch. Next step going to add options to leave out skey and kerb
because they add dependancies - will leave others in as they have no effect
unless specifically requested by the user. May consider a use flag to leave
them all off but for the time being I'll try to get it working.
Comment 8 Daniel Black (RETIRED) gentoo-dev 2004-05-19 20:07:30 UTC
johntheripper-1.6-r3 commited - this should fix bug 49988 too. Next - bug 44203 and bug 42751.

Almost acheived your goal - if I add an egg use flag for its patch I'm there. This isn't thoughly tested yet so please report any faults.

After that I'll get the other arch testers to give it a go.
Comment 9 Daniel Black (RETIRED) gentoo-dev 2004-05-20 20:18:48 UTC
Ghislain, can you be more specific about the error you got please. Will look at it tommorow. BTW I've got the next patch set for the next version ready - just got to do some more testing.
Comment 10 Daniel Black (RETIRED) gentoo-dev 2004-05-21 18:49:22 UTC
Added depencies skey openssl to runtime upon use flag. Depends should be good now. (reminder to self - need fix to prevent compile warnings - already in 1.6.37)
Comment 11 Daniel Black (RETIRED) gentoo-dev 2004-05-24 16:08:33 UTC
Arch testing in bug #44203. I think skey is fundamentially broken - fails john -test and another real senario I made. I've emailed the author so well see. It may end up being dropped.