Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 513512 - net-dialup/ppp-2.4.6-r1 - missing semicolon in /etc/ppp/ip-up.d/50-initd.sh and /etc/ppp/ip-down.d/50-initd.sh
Summary: net-dialup/ppp-2.4.6-r1 - missing semicolon in /etc/ppp/ip-up.d/50-initd.sh a...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
: 513550 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-06-16 21:57 UTC by Daniel Kenzelmann
Modified: 2014-06-18 18:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Kenzelmann 2014-06-16 21:57:49 UTC
openrc with netifrc

Network with PPPoE (ADSL) connection on eth0
Internal network on eth1

excerpt from /etc/conf.d/net:

config_eth0="null"
link_ppp0="eth0"
pppd_ppp0="noauth updetach defaultroute persist holdoff 10 lcp-echo-interval 15 lcp-echo-failure 3 debug lock maxfail 0 +ipv6 ipv6cp-use-ipaddr"

plugins_ppp0="pppoe"
username_ppp0='xxxxx'
password_ppp0='xxxxx'


postup() {
        /usr/bin/logger "ADSL Postup"
        return 0
}

predown() {
        /usr/bin/logger "ADSL Predown"
        return 0
}


When starting

/etc/init.d/net.ppp0 start

The ppp0 device is up and running, however the postup function is never called, only the Predown is visible in syslog. (so it is not just "delayed")

-----------------------

Portage 2.2.10 (default/linux/amd64/13.0, gcc-4.8.3, glibc-2.19-r1, 3.15.0-gentoo-r1 x86_64)
=================================================================
System uname: Linux-3.15.0-gentoo-r1-x86_64-AMD_E-350_Processor-with-gentoo-2.2
KiB Mem:    16028700 total,  15253476 free
KiB Swap:          0 total,         0 free
Timestamp of tree: Mon, 16 Jun 2014 16:45:01 +0000
ld GNU ld (GNU Binutils) 2.24
app-shells/bash:          4.2_p47
dev-lang/python:          2.7.6-r1, 3.3.5, 3.4.0
dev-util/cmake:           2.8.12.2-r1
dev-util/pkgconfig:       0.28-r1
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.14.1
sys-devel/binutils:       2.24-r3
sys-devel/gcc:            4.8.3
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2-r1
sys-devel/make:           4.0-r1
sys-kernel/linux-headers: 3.15 (virtual/os-headers)
sys-libs/glibc:           2.19-r1
Repositories: gentoo x-portage
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.5/ext-active/ /etc/php/cgi-php5.5/ext-active/ /etc/php/cli-php5.5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/usr/distfiles"
EMERGE_DEFAULT_OPTS="--quiet-build=n"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="acl amd64 bzip2 cli cracklib crypt cxx dri gdbm gnutls iconv idn iproute2 ipv6 lzma maildir mmx modules multilib ncurses nls nptl offensive opengl pam pcre readline session speex spice sse sse2 sse3 sse4a ssl ssse3 syslog tcpd udev unicode usb vdpau vhosts vorbis xattr zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="de de_DE en en_GB en_US zh zh_CN" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5 php5-4" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3 python3_4" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
USE_PYTHON="2.7 3.3 3.4"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, MAKEOPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Daniel Kenzelmann 2014-06-17 06:09:52 UTC
Running
/etc/init.d/net.ppp0 status
gives
 * status: inactive

even though ppp0 is up

---------
ppp0: flags=4305<UP,POINTOPOINT,RUNNING,NOARP,MULTICAST>  mtu 1492
        inet X.X.X.X  netmask 255.255.255.255  destination X.X.X.X
        ppp  txqueuelen 3  (Point-to-Point Protocol)
        RX packets 59409  bytes 24799351 (23.6 MiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 62346  bytes 9047366 (8.6 MiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0
Comment 2 Daniel Kenzelmann 2014-06-17 07:06:26 UTC
This might be the problem:
In
/lib/netifrc/net/iproute2.sh:

is_oper_up()
{
        local iface="$1"
        [ -z "$iface" ] && iface="$IFACE"
        read state </sys/class/net/"${iface}"/operstate
        [ "x$state" = "up" ]
}


 /sys/class/net/ppp0/operstate contains "unknown" instead of "up"

Thus, the ppp0 device never is identified as being up.

seems other software also had issues with this:
https://github.com/jaor/xmobar/pull/98
Comment 3 Daniel Kenzelmann 2014-06-17 08:44:34 UTC
Hmm, shouldn't that fail everytime anyways?
How is 
[ "x$state" = "up" ]
supposed to be ever true?
instead of
[ "x$state" = "xup" ]

Totally confused now, maybe just disregard my previous comment.
Comment 4 Daniel Kenzelmann 2014-06-17 09:17:39 UTC
FOUND THE ERROR!!!

there is a typo in /etc/ppp/ip-up.d/50-initd.sh

if [ -r /run/openrc/softlevel ] then

should be:

if [ -r /run/openrc/softlevel ] ; then


Now postup gets started correctly!
Comment 5 Daniel Kenzelmann 2014-06-17 09:35:37 UTC
opened new Bug 513550 for this issue to clarify that netifrc is not to blame :-)
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2014-06-17 11:33:19 UTC
*** Bug 513550 has been marked as a duplicate of this bug. ***
Comment 7 Sergey Popov gentoo-dev 2014-06-17 13:58:01 UTC
+*ppp-2.4.6-r2 (17 Jun 2014)
+
+  17 Jun 2014; Sergey Popov <pinkbyte@gentoo.org> -ppp-2.4.6.ebuild,
+  -ppp-2.4.6-r1.ebuild, +ppp-2.4.6-r2.ebuild:
+  Revision bump: fix missing semicolon in ip-up.d/50-initd.sh script, update
+  patchset, wrt bug #513512. Thanks to Daniel Kenzelmann <gentoo AT k8n.de> for
+  discovering this issue. Drop old revisions

That was my fault, fixed now
Comment 8 Daniel Kenzelmann 2014-06-17 14:02:07 UTC
Did you also fix it in

/etc/ppp/ip-down.d/50-initd.sh 

The same error is in there.

(I'm not using postdown() function so I didn't notice that earlier)
Comment 9 Daniel Kenzelmann 2014-06-18 18:38:39 UTC
Issue is fixed in

/etc/ppp/ip-up.d/50-initd.sh

however it is still present in 

/etc/ppp/ip-down.d/50-initd.sh



if [ -r /run/openrc/softlevel ] then

should be

if [ -r /run/openrc/softlevel ]; then
Comment 10 Sergey Popov gentoo-dev 2014-06-18 18:52:21 UTC
+*ppp-2.4.6-r3 (18 Jun 2014)
+
+  18 Jun 2014; Sergey Popov <pinkbyte@gentoo.org> -ppp-2.4.6-r2.ebuild,
+  +ppp-2.4.6-r3.ebuild:
+  Revision bump: finally fix bug #513512, thanks again to Daniel Kenzelmann
+  <gentoo AT k8n.de>. Drop old revision

Blame me for my blindness again!