Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 508692 - sys-fs/mdadm-3.3-r2 - checkarray --all queues the check only for the first array
Summary: sys-fs/mdadm-3.3-r2 - checkarray --all queues the check only for the first array
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-04-25 15:39 UTC by Anna Tikhomirova
Modified: 2015-09-26 13:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch (file_508692.txt,374 bytes, text/plain)
2014-04-25 15:39 UTC, Anna Tikhomirova
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Tikhomirova 2014-04-25 15:39:59 UTC
Created attachment 375688 [details]
proposed patch

sys-fs/mdadm-3.3-r2 introduced checkarray script from the debian patchset. 

However this script doesn't behave correctly if you have more than one array and start the script with --all argument (or pass multiple arrays in the command line) and without --idle, --slow, --fast or --realtime arguments. For example, just: checkarray --all.

In this case, the script queues the check only for the first array from the list.

It seems that there is an erroneous 'break', which breaks the whole 'for array in $arrays' loop.
Comment 1 Alexander Tsoy 2015-09-26 13:22:21 UTC
Confirming this:

$ sudo checkarray --all
checkarray: I: check queued for array md126.
$ sudo checkarray --all --idle                              
checkarray: I: check queued for array md126.
checkarray: I: selecting idle I/O scheduling class and 15 niceness for resync of md126.
checkarray: I: check queued for array md127.
checkarray: I: selecting idle I/O scheduling class and 15 niceness for resync of md127.