Created attachment 375152 [details, diff] patch against gx86 version After the solaris patch got merged upstream and interix support was dropped, there is only one trivial change left to link a shared lib on Darwin.
Comment on attachment 375152 [details, diff] patch against gx86 version >+ if [[ ${CHOST} == *-darwin* ]] ; then >+ sed -i \ >+ -e "/libunrar/s:.so:$(get_libname ${PV%.*.*}):" \ don't duplicate common ones. use an array: local sed_args=( -e .... ) ... sed -i "${sed_args[@]}" Makefile || die >+ -e "s:-shared:-dynamiclib -install_name ${EPREFIX}/usr/lib/libunrar$(get_libname ${PV%.*.*}):" \ shouldn't you be using $(get_libdir) here ?
Created attachment 375700 [details, diff] patch against gx86 version (In reply to SpanKY from comment #1) > Comment on attachment 375152 [details, diff] [details, diff] > patch against gx86 version > > >+ if [[ ${CHOST} == *-darwin* ]] ; then > >+ sed -i \ > >+ -e "/libunrar/s:.so:$(get_libname ${PV%.*.*}):" \ > > don't duplicate common ones. use an array: > local sed_args=( > -e .... > ) > ... > sed -i "${sed_args[@]}" Makefile || die Done. > > >+ -e "s:-shared:-dynamiclib -install_name ${EPREFIX}/usr/lib/libunrar$(get_libname ${PV%.*.*}):" \ > shouldn't you be using $(get_libdir) here ? Not 100% needed as prefix is no-multilib, but it doesn't hurt to put it.
>Not 100% needed as prefix is no-multilib, Yet. It will be in the future.
(In reply to Christoph Junghans from comment #2) lgtm; feel free to commit
+ 09 May 2014; Christoph Junghans <ottxor@gentoo.org> unrar-5.1.4.ebuild: + added prefix support (bug #507936) +
