Bug 505320 – dev-libs/leveldb - libmemenv.a with PIC required for net-p2p/bitcoin{-qt,d}

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Luke-Jr 2014-03-22 04:57:56 UTC]

net-p2p/bitcoin{-qt,d}-0.9.0 link as PIE, thus can only contain PIC; but they also use LevelDB's libmemenv.a, which is built without -fPIC.

[Comment 1 Tolga Dalman 2014-03-22 15:42:43 UTC]

I agree. Have you reported upstream already ? It'd be great, if they would switch to a proper build system (autotools, cmake, ...).

[Comment 2 Luke-Jr 2014-03-22 20:12:52 UTC]

https://code.google.com/p/leveldb/issues/detail?id=230

[Comment 3 Luke-Jr 2014-03-29 20:13:23 UTC]

Created attachment 373844 [details, diff]
leveldb-1.9.0-memenv-so.patch

Patch to build libmemenv.so*

[Comment 4 Luke-Jr 2014-03-29 20:15:16 UTC]

Created attachment 373846 [details, diff]
patch to make leveldb-1.15.0-r1.ebuild

Similar changes make the patch apply cleanly to all versions in the tree. "bitcoin" overlay has revbumps for all versions.

[Comment 5 Anthony Basile 2014-06-30 01:17:06 UTC]

@Luke-jr what versions in the tree should get this patch?

@patrick + Johan.  Same issue as with bug #506184.  We'd like to move forward since this has been blocking bitcoin for several months now.

[Comment 6 Johan Bergström 2014-06-30 01:20:33 UTC]

Hey. I'll have a look at this now. Not sure why I've missed these emails/bugs. Obviously not blaming ^_^

[Comment 7 Luke-Jr 2014-06-30 01:27:46 UTC]

(In reply to Anthony Basile from comment #5)
> @Luke-jr what versions in the tree should get this patch?

Anything we want to work with bitcoin{d,-qt}

[Comment 8 Johan Bergström 2014-06-30 07:58:57 UTC]

Sorry again for the delay. I've tried and looked at the patch. I'm ok with it.

[Comment 9 Anthony Basile 2014-07-29 15:54:01 UTC]

(In reply to Johan Bergström from comment #8)
> Sorry again for the delay. I've tried and looked at the patch. I'm ok with
> it.

Added.  Thanks to mrueg for jogging my memory.

[Comment 10 Oliver Deppert 2014-08-02 08:40:07 UTC]

Hi,

thanks for the patch...

the patch is already upstream under "files"....but the "modified" epatch to incoporate the new patch is still missing...

could you please provide the "new" ebuild file with the "epatch" command linking to the memenv-so.patch?

kind regards,
Oliver

[Comment 11 Oliver Deppert 2014-08-02 08:47:02 UTC]

Hi,

the patch is included in:
leveldb-1.15.0-r1.ebuild

but missing in:
leveldb-1.9.0-r5.ebuild
leveldb-1.9.0-r6.ebuild

regards,
Oliver

[Comment 12 Anthony Basile 2015-07-04 19:39:11 UTC]

leveldb-1.15.0-r1 was marked stable for amd64, arm and x86.  And the virtual was updated as well.