Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 505174 - net-misc/tor-0.2.4.21 USE=-ecc - src/test/test.c:943:16: error: 'NTOR_ONIONSKIN_LEN' undeclared (first use in this function)
Summary: net-misc/tor-0.2.4.21 USE=-ecc - src/test/test.c:943:16: error: 'NTOR_ONIONSK...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL: https://trac.torproject.org/projects/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-20 14:06 UTC by parafin
Modified: 2014-06-11 10:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log,40.95 KB, text/plain)
2014-03-20 14:06 UTC, parafin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description parafin 2014-03-20 14:06:00 UTC
Created attachment 373104 [details]
build log

Building fails with following error:
i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I.  -DSHARE_DATADIR="\"/usr/share\"" -DLOCALSTATEDIR="\"/var/lib\"" -DBINDIR="\"/usr/bin\"" -I"./src/or" -I"./src/ext" -I./src/common     -O2 -march=core2 -fomit-frame-pointer -ftracer -pipe -Wall -fno-strict-aliasing -c -o src/test/src_test_test-test_containers.o `test -f 'src/test/test_containers.c' || echo './'`src/test/test_containers.c
src/test/test.c: In function 'test_onion_queues':
src/test/test.c:943:16: error: 'NTOR_ONIONSKIN_LEN' undeclared (first use in this function)
src/test/test.c:943:16: note: each undeclared identifier is reported only once for each function it appears in
src/test/test.c:943:11: warning: unused variable 'buf2' [-Wunused-variable]
make[1]: *** [src/test/src_test_test-test.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/usr/portage/local/portage/net-misc/tor-0.2.4.20/work/tor-0.2.4.20'
make: *** [all] Error 2

Looks like this upstream bug (which was already fixed): https://trac.torproject.org/projects/tor/ticket/9700

Builds fine with USE=ecc.

spobs ~ # emerge --info '=net-misc/tor-0.2.4.20::gentoo'
Portage 2.2.8-r1 (default/linux/x86/13.0/desktop, gcc-4.7.3, glibc-2.17, 3.3.3 i686)
=================================================================
                        System Settings
=================================================================
System uname: Linux-3.3.3-i686-Intel-R-_Core-TM-2_CPU_6300_@_1.86GHz-with-gentoo-2.2
KiB Mem:     3000124 total,    155612 free
KiB Swap:    1048508 total,   1046616 free
Timestamp of tree: Wed, 19 Mar 2014 20:30:01 +0000
ld GNU ld (GNU Binutils) 2.23.2
distcc 3.1 i686-pc-linux-gnu [disabled]
ccache version 3.1.9 [enabled]
app-shells/bash:          4.2_p45
dev-lang/python:          2.7.5-r3
dev-util/ccache:          3.1.9-r3
dev-util/cmake:           2.8.11.2
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12.4
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.13, 2.69
sys-devel/automake:       1.10.3, 1.11.6, 1.12.6, 1.13.4
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.3-r1
sys-devel/gcc-config:     1.7.3
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.9 (virtual/os-headers)
sys-libs/glibc:           2.17
Repositories: gentoo local
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="*"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=core2 -fomit-frame-pointer -ftracer -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/bind"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -march=core2 -fomit-frame-pointer -ftracer -pipe"
DISTDIR="/data/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps y --quiet-build y --keep-going y"
FCFLAGS="-O2 -march=i686 -pipe"
FEATURES="assume-digests binpkg-logs ccache config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -march=i686 -pipe"
GENTOO_MIRRORS="http://mirror.yandex.ru/gentoo-distfiles/"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/usr/portage/local"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
USE="X a52 aac adns alsa amr apache2 audiofile bash-completion berkdb bluray bzip2 cairo caps cddb cdparanoia cracklib crypt css cups curl cxx dba dbus dri dts dvd dvdr dvdread enca encode expat faac faad fbcon ffmpeg flac fontconfig foomaticdb ftp gcrypt gd gdbm geoip gif glib gmp gpm graphviz gtk iconv idn imap ipv6 ithreads jpeg jpeg2k kerberos lcms libsamplerate lzma lzo mad matroska milter mmx mmxext mng mp3 mpeg ncurses network nls nptl nsplugin offensive ogg opengl openssl pam pcap pcre pdf perl pic png ppds pulseaudio python quicktime readline recode ruby sasl session sndfile speex spell sqlite sse sse2 sse3 ssl ssse3 svg tcpd theora threads threadsafe tiff truetype unicode usb vdpau vorbis vpx win32codecs x264 x86 xcb xml xpm xv xvid zlib" ABI_X86="32" APACHE2_MODULES="alias auth_basic authn_file authz_host authz_user autoindex cgid dir info log_config mime mime_magic negotiation rewrite setenvif so speling status" ELIBC="glibc" INPUT_DEVICES="keyboard mouse void" KERNEL="linux" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7" RUBY_TARGETS="ruby19" SANE_BACKENDS="plustek" USERLAND="GNU" VIDEO_CARDS="intel nvidia"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, SYNC, USE_PYTHON

=================================================================
                        Package Settings
=================================================================

net-misc/tor-0.2.4.20 was built with the following:
USE="ecc threads -bufferevents -nat-pmp (-selinux) -stats -tor-hardening -transparent-proxy -upnp -web"
Comment 1 Anthony Basile gentoo-dev 2014-03-20 15:36:19 UTC
0.2.4.20 is on the way out, can you test 0.2.4.21.
Comment 2 parafin 2014-03-20 16:45:41 UTC
just tested, same issue with 0.2.4.21
Comment 3 Anthony Basile gentoo-dev 2014-03-20 16:50:15 UTC
(In reply to parafin from comment #2)
> just tested, same issue with 0.2.4.21

Thanks this should go upstream.
Comment 4 parafin 2014-03-20 16:51:27 UTC
0.2.5.2_alpha on the other hand compiles fine
Comment 5 Anthony Basile gentoo-dev 2014-03-20 16:57:04 UTC
Upstream has a fix, but I don't think it was backported.  I'll try pinging armadev on IRC about it.  Else I'll open a new upstream bug.

https://trac.torproject.org/projects/tor/ticket/9700
Comment 6 Anthony Basile gentoo-dev 2014-03-20 19:00:25 UTC
<nickm> If you want to patch before the next 0.2.4.x release comes out, the git commit to grab is a83abcf5ee5cb8fe245bc97e089e082f62921194

I think we can wait unless you really need this.  We should not be encouraging USE=-ecc in the first place since it gives weaker crypto.  I exposed the choice as a USE flag because ... well ... we are Gentoo.  I'd like to hear arguments for wanting USE=-ecc.
Comment 7 parafin 2014-03-20 19:11:35 UTC
I don't really care about if this feature is on or off. I just think that USE flag should work if it is present and not masked, otherwise there's no point in providing it, only problems for occasional users.
Comment 8 Anthony Basile gentoo-dev 2014-03-24 13:23:54 UTC
(In reply to parafin from comment #7)
> I don't really care about if this feature is on or off. I just think that
> USE flag should work if it is present and not masked, otherwise there's no
> point in providing it, only problems for occasional users.

Okay I committed the fix without rev bump.  Can you try to emerge 0.2.4.21 again.  I did not backport to 0.2.4.20 since I will be asking for stabilization of .21 soon.

Its working for me, so I'll close this fixed, but please reopen if its still not working.

Thanks for the report!
Comment 9 parafin 2014-03-24 14:06:39 UTC
yep, fix works.
Comment 10 Jesse Adelman 2014-06-11 00:03:08 UTC
Ah, been hitting this bug for a long time now with 0.2.4.20. Any hope for a stable amd64 bump? Thanks.
Comment 11 Anthony Basile gentoo-dev 2014-06-11 10:41:12 UTC
(In reply to Jesse Adelman from comment #10)
> Ah, been hitting this bug for a long time now with 0.2.4.20. Any hope for a
> stable amd64 bump? Thanks.

See bug #510564