Bug 500836 – Output for subslot rebuilds too similar to output for circular deps

• Status: CONFIRMED
• Product: Portage Development

[Description Patrick Lauer 2014-02-10 03:04:43 UTC]

Compare these two:

The following packages are causing rebuilds:                                                                                                                                                                                                 

  (dev-libs/libgcrypt-1.5.3::gentoo, ebuild scheduled for merge) causes rebuilds for:
    (dev-libs/libxslt-1.1.28-r1::gentoo, ebuild scheduled for merge)


(virtual/rubygems-7::gentoo, ebuild scheduled for merge) depends on
 (dev-ruby/rubygems-2.0.14::gentoo, ebuild scheduled for merge) (runtime)
  (dev-ruby/minitest-4.7.4-r1::gentoo, ebuild scheduled for merge) (buildtime)
   (virtual/rubygems-7::gentoo, ebuild scheduled for merge) (buildtime)

Both use round brackets and indentation. This is mildly confusing, I would prefer a visual distinction (like using square brackets for subslot rebuilds)

Otherwise, at first glance, these two outputs can be confused, which is not a good thing :) (Because then you need to carefully read it, and the subslot rebuild output is usually 'don't care' - whereas circular deps aren't)

[Comment 1 Sebastian Luther (few) 2014-02-10 17:19:59 UTC]

(In reply to Patrick Lauer from comment #0)
> Compare these two:
> 
> The following packages are causing rebuilds:                                
> 
> 
>   (dev-libs/libgcrypt-1.5.3::gentoo, ebuild scheduled for merge) causes
> rebuilds for:
>     (dev-libs/libxslt-1.1.28-r1::gentoo, ebuild scheduled for merge)
> 
> 
> (virtual/rubygems-7::gentoo, ebuild scheduled for merge) depends on
>  (dev-ruby/rubygems-2.0.14::gentoo, ebuild scheduled for merge) (runtime)
>   (dev-ruby/minitest-4.7.4-r1::gentoo, ebuild scheduled for merge)
> (buildtime)
>    (virtual/rubygems-7::gentoo, ebuild scheduled for merge) (buildtime)
> 

There's nothing between the last line of the rebuilds and the first line of the circular deps? If yes, this should be changed.

> Both use round brackets and indentation. This is mildly confusing, I would
> prefer a visual distinction (like using square brackets for subslot rebuilds)
> 

I'd rather not change this. These strings just come from Package.__str__.

> Otherwise, at first glance, these two outputs can be confused, which is not
> a good thing :) (Because then you need to carefully read it, and the subslot
> rebuild output is usually 'don't care' - whereas circular deps aren't)

I'm not opposed to making the distinction more clear, but we need better ideas how to do so.