Bug 497188 – x11-misc/xplanet-1.3.0 USE=gif - gif.c:244:1: error: static declaration of ‘QuantizeBuffer’ follows non-static declaration

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description urcindalo 2014-01-05 23:59:31 UTC]

After the stabilization of libpng.1.6.8 on a stable amd64 box, xplanet-1.3.0 fails to rebuild even after USE="-png -gif". This is the error I get:
===========
make[3]: Entering directory `/var/tmp/portage/x11-misc/xplanet-1.3.0/work/xplanet-1.3.0/src/libimage'
x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../..  -I../../src   -march=native -O2 -pipe -c -o Image.o Image.cpp
x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../..  -I../../src   -march=native -O2 -pipe -c -o ReadImage.o ReadImage.cpp
x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../..  -I../../src   -march=native -O2 -pipe -c -o WriteImage.o WriteImage.cpp
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../..  -I../../src   -march=native -O2 -pipe -c bmp.c
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../..  -I../../src   -march=native -O2 -pipe -c gif.c
ReadImage.cpp: In function ‘bool ReadImage(const char*, int&, int&, unsigned char*&, unsigned char*&)’:
ReadImage.cpp:56:27: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
gif.c:244:1: error: static declaration of ‘QuantizeBuffer’ follows non-static declaration
In file included from gif.c:25:0:
/usr/include/gif_lib.h:222:5: note: previous declaration of ‘QuantizeBuffer’ was here
gif.c: In function ‘write_gif’:
gif.c:511:5: error: unknown type name ‘bool’
gif.c:511:29: error: ‘false’ undeclared (first use in this function)
gif.c:511:29: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [gif.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory `/var/tmp/portage/x11-misc/xplanet-1.3.0/work/xplanet-1.3.0/src/libimage'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/x11-misc/xplanet-1.3.0/work/xplanet-1.3.0/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/x11-misc/xplanet-1.3.0/work/xplanet-1.3.0'
make: *** [all] Error 2
 * ERROR: x11-misc/xplanet-1.3.0::gentoo failed (compile phase):
 *   emake failed
=======

[Comment 1 urcindalo 2014-01-06 00:11:36 UTC]

I correct myself. The error is only with the gif support.
So, xplanet correctly build with png support without gif support: USE="png -gif"

Since it is gif support that fails, maybe I just came upon this after needing to recompile xplanet as a consequence of the recentt libpng update, without being libpng the culprit for the failure.

[Comment 2 urcindalo 2014-01-06 21:08:13 UTC]

media-libs/giflib-4.2.3 (~amd64) solves the issue, but the media-libs/giflib-4.1.6-r2 stable amd64 version triggers the build failure.

[Comment 3 Jeroen Roovers (RETIRED) 2014-01-24 19:45:25 UTC]

The patch fixing bug #488406 shouldn't have been applied to the stable ebuild.

[Comment 4 Jeroen Roovers (RETIRED) 2014-01-24 19:48:28 UTC]

-r1 now applies the patch and depends on newer (unstable) giflib while -r0 properly does not apply the patch and depends on stable giflib.