Your eclass inherits base.eclass. For several reasons, we at the QA team would like to remove base, and so we ask that you remove the inherit. See bug 497022 for notes on transitioning your eclass away from the base inherit and checking for problems that could crop up.
it doesnt harm here and duplicating code is certainly not good QA :) so, if you want to kill base.eclass, why not, but please provide another eclass with an equivalent src_preprare
(In reply to Alexis Ballier from comment #1) > it doesnt harm here and duplicating code is certainly not good QA :) > > so, if you want to kill base.eclass, why not, but please provide another > eclass with an equivalent src_preprare i have not seen any action 2 months later; closing as wontfix, please reopen if im wrong
aballier, I was using base.eclass for xfconf.eclass and asked the same questions, and managed to replace the base_src_prepare with a 2-liner using just eutils.eclass [[ ${PATCHES[@]} ]] && epatch "${PATCHES[@]}" epatch_user first one to process PATCHES=(), although I knew they were all in array before doing it that simple, followed by users own patches the last real blocker for getting rid of base.eclass was missing einstalldocs, but that's in eutils.eclass now too can you please recheck?
(In reply to Samuli Suominen from comment #3) that's still duplicating "code" for no good reason; feel free to propose a patch though: i'm not even convinced that getting rid of base.eclass is a good idea (instead of e.g. adapting its API for newer EAPIs) so I wont work on this. FWIW, an excerpt of the eclass doc: # It inherits texlive-common and base for supporting patching via the PATCHES # bash array. and indeed all consumers use an array.
Created attachment 372200 [details, diff] Patch for texlive-module.eclass (In reply to Alexis Ballier from comment #4) > that's still duplicating "code" for no good reason; What, two lines? At the same time, it gets rid of inheriting lots of unused code from base.eclass. > feel free to propose a patch though: Patch is attached. I've tested it with all ebuilds that inherit texlive-module and define a PATCHES array. I've also checked if ebuilds inheriting texlive-module call any base_* functions directly, and found 3 ebuilds of the dev-texlive/texlive-context package doing this in their src_prepare(): rm -rf texmf-dist/scripts/context/stubs/mswin || die base_src_prepare These need to be changed to call texlive-module_src_prepare instead.
(In reply to Ulrich Müller from comment #5) > (In reply to Alexis Ballier from comment #4) > > that's still duplicating "code" for no good reason; > > What, two lines? your diff is more than two lines I'm afraid :) > At the same time, it gets rid of inheriting lots of unused > code from base.eclass. hence the idea to move this to its own eclass > > feel free to propose a patch though: > > Patch is attached. I've tested it with all ebuilds that inherit > texlive-module and define a PATCHES array. patch lgtm (with one unrelated change but that's ok since i prefer it that way :p), feel free to commit (with the ebuild fixes you mentionned)
(In reply to Alexis Ballier from comment #6) > patch lgtm (with one unrelated change but that's ok since i prefer it that > way :p), feel free to commit Committed. > (with the ebuild fixes you mentionned) Committed, too.
