Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 496336 - sys-apps/pciutils - make DNS optional
Summary: sys-apps/pciutils - make DNS optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-12-29 01:18 UTC by David Hendricks
Modified: 2014-01-01 15:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pciutils-3.2.0-r2.ebuild (pciutils-3.2.0-r2.ebuild,2.30 KB, text/plain)
2013-12-29 01:18 UTC, David Hendricks
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Hendricks 2013-12-29 01:18:04 UTC
This makes DNS=yes/no optional as a USE flag. The reason one might want to disable this is to remove the dependency on libresolv, which has spotty support when compiling with alternative C libraries (e.g. uClibc).

From pciutils README:
  DNS=yes/no    Enable support for querying the central database of PCI IDs
                using DNS.  Requires libresolv (which is available on most
                systems as a part of the standard libraries) and tries to
                autodetect its presence if the option is not specified.

The new ebuild amounts to changing a hard-coded argument to make into using usex:
16c16
< IUSE="+kmod static-libs zlib"
---
> IUSE="+dns +kmod static-libs zlib"
42c42
<               DNS="yes" \
---
>               DNS="$(usex dns)" \
Comment 1 David Hendricks 2013-12-29 01:18:39 UTC
Created attachment 366402 [details]
pciutils-3.2.0-r2.ebuild
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2013-12-30 00:00:05 UTC
Comment on attachment 366402 [details]
pciutils-3.2.0-r2.ebuild

--- pciutils-3.2.0.ebuild       2013-09-05 20:08:13.170017001 +0200
+++ -   2013-12-30 00:59:31.410007670 +0100
@@ -13,7 +13,7 @@
 LICENSE="GPL-2"
 SLOT="0"
 KEYWORDS="alpha amd64 arm hppa ia64 m68k ~mips ppc ppc64 s390 sh sparc x86 ~amd64-fbsd ~x86-fbsd ~x64-freebsd ~amd64-linux ~arm-linux ~x86-linux"
-IUSE="+kmod static-libs zlib"
+IUSE="+dns +kmod static-libs zlib"
 
 # Have the sub-libs in RDEPEND with [static-libs] since, logically,
 # our libssl.a depends on libz.a/etc... at runtime.
@@ -39,7 +39,7 @@
                HOST="${CHOST}" \
                CROSS_COMPILE="${CHOST}-" \
                CC="$(tc-getCC)" \
-               DNS="yes" \
+               DNS="$(usex dns)" \
                IDSDIR='$(SHAREDIR)/misc' \
                MANDIR='$(SHAREDIR)/man' \
                PREFIX="${EPREFIX}/usr" \
Comment 3 SpanKY gentoo-dev 2013-12-31 19:21:10 UTC
should be all set now in the tree; thanks for the report!

Commit message: Add USE=dns to control uncommon dns behavior
http://sources.gentoo.org/sys-apps/pciutils/metadata.xml?r1=1.7&r2=1.8
http://sources.gentoo.org/sys-apps/pciutils/pciutils-3.2.1.ebuild?r1=1.1&r2=1.2