Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 495984 - x11-libs/libqxt - QxtGlobalShortcut should support multimedia keys frequently found on keyboards.
Summary: x11-libs/libqxt - QxtGlobalShortcut should support multimedia keys frequently...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 326673
  Show dependency tree
 
Reported: 2013-12-25 11:53 UTC by Georg Rudoy
Modified: 2017-12-25 02:53 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch fixing the issue (libqxt-media-keys.patch,15.46 KB, patch)
2013-12-25 11:54 UTC, Georg Rudoy
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Georg Rudoy 2013-12-25 11:53:55 UTC
Stock upstream implementation of global shortcuts in Qxt doesn't support multimedia keys.

Qxt issue tracker has a corresponding issue opened for almost 3.5 years without any reaction from upstream: http://dev.libqxt.org/libqxt-old-hg/issue/75/qxtglobalshortcut-does-not-support-media . Applications using libqxt typically bundle it with the proper fix, like Clementine in the link above or LeechCraft.

Reproducible: Always

Steps to Reproduce:
1. Install app-leechcraft/lc-{lmp,gacts}-9999.
2. Try setting a shortcut containing a multimedia button (like Play/Pause) in LC settings for some action in LMP.
Actual Results:  
Pressing the assigned key doesn't trigger the corresponding action.

Expected Results:  
The corresponding action should be triggered.
Comment 1 Georg Rudoy 2013-12-25 11:54:56 UTC
Created attachment 366172 [details, diff]
Patch fixing the issue

The patch is taken from Fedora at http://pkgs.fedoraproject.org/cgit/libqxt.git/tree/libqxt-media-keys.patch .

This is also the same patch applied to lc-gacts bundled version of Qxt. Seems to work for me.
Comment 2 Davide Pesavento (RETIRED) gentoo-dev 2013-12-26 01:20:19 UTC
Patch added in -r2
Comment 3 Nikoli 2014-02-24 16:08:20 UTC
The patch is not same as in https://github.com/clementine-player/Clementine/blob/master/3rdparty/qxt/media-keys.patch , why part of it was removed?
Comment 4 Georg Rudoy 2014-02-24 16:36:27 UTC
Hard to say, I've just borrowed the patch from Fedora.

Looks like the difference should be put back to Gentoo's patch. Thanks for noticing this.
Comment 5 Nikoli 2014-02-24 16:46:04 UTC
Please also consider adding this patch:
https://github.com/clementine-player/Clementine/blob/master/3rdparty/qxt/meta-modifier.patch

Then it will be possible to use in clementine ebuilds system qxt copy instead of bundled.
Comment 6 Davide Pesavento (RETIRED) gentoo-dev 2014-02-24 16:51:43 UTC
(In reply to Nikoli from comment #5)
> Please also consider adding this patch:
> https://github.com/clementine-player/Clementine/blob/master/3rdparty/qxt/
> meta-modifier.patch
> 

Is that an upstream patch?
Comment 7 Nikoli 2014-02-24 16:59:00 UTC
Seems author of patch is David Sansome, main Clementine dev:
https://github.com/clementine-player/Clementine/commit/35f0c65046c6e25d3749f6a2be8648b73c64e33a
https://github.com/clementine-player/Clementine/issues/329

Do not know if libqxt devs accepted and applied the patch.
Comment 8 Michael Palimaka (kensington) gentoo-dev 2017-12-25 02:53:38 UTC
libqxt upstream is dead and there's only a couple of Qt 4 revdeps still using this package. Once they're cleaned up, this package will be last rited.