Bug 494794 – sys-kernel/gentoo-sources - vmwgfx: correct fb_fix_screeninfo.line_length in check_var(), set_par()

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Christopher Friedt 2013-12-20 04:01:51 UTC]

Created attachment 365722 [details, diff]
patch against linux-3.10.7-gentoo

For old fogies that still like to use the non-kms FB (for various reasons), this patch makes screen drawing coherent.

As of linux-3.10.7-gentoo (and probably still in upstream), after updating fb_var_screeninfo.xres (via ioctl FBIOPUT_VSCREENINFO), the fb_fix_screeninfo.line_length is not updated accordingly.

This patch corrects it.

Please also see attached before / after screenshots.

[Comment 1 Christopher Friedt 2013-12-20 04:12:34 UTC]

Created attachment 365724 [details]
before.red.png

[Comment 2 Christopher Friedt 2013-12-20 04:24:32 UTC]

Created attachment 365726 [details]
after.red.jpg

[Comment 3 Christopher Friedt 2013-12-20 04:24:53 UTC]

Created attachment 365728 [details]
before.gradient.jpg

[Comment 4 Christopher Friedt 2013-12-20 04:25:15 UTC]

Created attachment 365730 [details]
after.gradient.jpg

[Comment 5 Christopher Friedt 2013-12-20 04:25:36 UTC]

Created attachment 365732 [details]
before.diag.jpg

[Comment 6 Christopher Friedt 2013-12-20 04:26:57 UTC]

Created attachment 365734 [details]
after.diag.jpg

[Comment 7 Mike Pagano 2014-01-30 17:31:04 UTC]

This really should be submitted and accepted upstream. Would you consider doing that?

[Comment 8 Christopher Friedt 2014-02-01 01:45:07 UTC]

(In reply to Mike Pagano from comment #7)
> This really should be submitted and accepted upstream. Would you consider
> doing that?

Yep - I'll fire off a patch this weekend.

[Comment 9 Christopher Friedt 2014-03-03 14:11:25 UTC]

Well, I did fire off a patch to the LKML and Dave Airlie, the maintainer. However, I haven't yet had any replies and have followed up numerous times.

After a couple of weeks, I thought maybe this was due to a merge window. Not entirely clear yet.

http://lists.openwall.net/linux-kernel/2014/02/01/81

[Comment 10 Mike Pagano 2014-05-01 17:56:00 UTC]

I see some changes in this file, do you still experience this issue?

[Comment 11 Christopher Friedt 2014-05-01 18:02:27 UTC]

Should be upstream now. Shall I close / mark resolved?

[snip]
drm/vmwgfx: correct fb_fix_screeninfo.line_length

to the linux-3.8.y-queue branch of the 3.8.y.z extended stable tree
which can be found at:

 http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.8.y-queue

This patch is scheduled to be released in version 3.8.13.22.
[/snip]

[Comment 12 Mike Pagano 2014-05-01 18:30:10 UTC]

Excellent, looks like it will be in 3.15. We can leave this open until then. 

git tag --contains aa6de142c901cd2d90ef08db30ae87da214bedcc
v3.15-rc1
v3.15-rc2
v3.15-rc3

[Comment 13 Thomas Deutschmann (RETIRED) 2014-05-01 18:34:11 UTC]

@ Christopher: Did you also submit the patch for the 3.10.x kernel? I don't see it in 3.10.38 and http://git.kernel.org/cgit/linux/kernel/git/stable/stable-queue.git/tree/queue-3.10

[Comment 14 Mike Pagano 2014-07-11 22:35:12 UTC]

In 3.15. Btw, also in 3.10.41