Bug 494748 – dev-util/pkgconfig-0.28-r1 - add multilib-minimal support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description kramlat 2013-12-19 14:31:51 UTC]

Created attachment 365678 [details]
pkgconfig-0.28-r1.ebuild

I have finally made a new ebuild for pkgconfig that uses the new multilib-minimal eclass.  This could be useful. I know that there are plans to eventually pull emul-linux-x86-baselibs, but this pkgconfig is ready for it.

[Comment 1 kramlat 2013-12-19 14:52:10 UTC]

thanks, this is the first ebuild I submitted.  that was very helpful for the re-filing.

[Comment 2 Jeroen Roovers (RETIRED) 2013-12-19 14:56:00 UTC]

Comment on attachment 365678 [details]
pkgconfig-0.28-r1.ebuild

--- pkgconfig-0.28.ebuild       2013-02-26 15:45:16.837133463 +0100
+++ -   2013-12-19 15:55:36.382205377 +0100
@@ -4,7 +4,7 @@
 EAPI=5
-inherit flag-o-matic libtool multilib
+inherit flag-o-matic libtool multilib-minimal
 MY_P=pkg-config-${PV}
@@ -31,7 +31,7 @@
 S=${WORKDIR}/${MY_P}
-DOCS=( AUTHORS NEWS README )
+DOCS=( ../pkg-config-0.28/AUTHORS ../pkg-config-0.28/NEWS ../pkg-config-0.28/README )
 src_prepare() {
        sed -i -e "s|^prefix=/usr\$|prefix=${EPREFIX}/usr|" check/simple.pc || die #434320
@@ -43,8 +43,9 @@
        fi
 }
-src_configure() {
+multilib_src_configure() {
        local myconf
+       multilib_is_native_abi
        if use internal-glib; then
                myconf+=' --with-internal-glib'
@@ -63,15 +64,21 @@
        [[ ${PV} == *9999* ]] && myconf+=' --enable-maintainer-mode'
-       econf \
+       ECONF_SOURCE="${S}" econf \
                --docdir="${EPREFIX}"/usr/share/doc/${PF}/html \
                --with-system-include-path="${EPREFIX}"/usr/include \
                --with-system-library-path="${EPREFIX}"/usr/$(get_libdir) \
                ${myconf}
 }
-src_install() {
+multilib_src_compile() {
+        default
+        multilib_is_native_abi
+}
+
+multilib_src_install() {
        default
+       multilib_is_native_abi
        if use prefix; then
                # Add an explicit reference to $EPREFIX to PKG_CONFIG_PATH to

[Comment 3 Michał Górny 2013-12-19 15:20:44 UTC]

Err, why would we want to work on multilib pkg-config when pkg-config doesn't install any libraries that could be different for multilib?

[Comment 4 Samuli Suominen (RETIRED) 2013-12-19 15:31:40 UTC]

(In reply to Michał Górny from comment #3)
> Err, why would we want to work on multilib pkg-config when pkg-config
> doesn't install any libraries that could be different for multilib?

doesn't make sense to me either

[Comment 5 Michał Górny 2013-12-19 15:36:35 UTC]

Well, theoretically we could have i686-pc-linux-pkgconfig that would make some of the hacks in multilib.eclass redundant in favor of plain $(tc-getPKG_CONFIG)...

[Comment 6 Samuli Suominen (RETIRED) 2014-03-27 06:58:15 UTC]

(In reply to Michał Górny from comment #5)
> Well, theoretically we could have i686-pc-linux-pkgconfig that would make
> some of the hacks in multilib.eclass redundant in favor of plain
> $(tc-getPKG_CONFIG)...

yes indeed, this makes sense, i've committed 0.28-r1 in tree