Modern autoconf has two data paths: datarootdir and datadir. The former is used for 'system global' data such as man pages, info files, .desktop files etc. The latter can be used for application-local data. Since games.eclass overrides --prefix, default datarootdir ends up being /usr/games/share. I think the eclass should explicitly pass --datarootdir=/usr/share in order to fix .desktop file, pixmap installs etc.
a problem is that we can probably not fix this without breaking a lot of stuff, can we? I was suggesting to drop base.eclass inherit for EAPI=6 anyway... maybe we can fix this along with that?
(In reply to Julian Ospald (hasufell) from comment #1) > a problem is that we can probably not fix this without breaking a lot of > stuff, can we? What stuff is going to be broken? I doubt many games actually use datarootdir at all, not to mention using it incorrectly. Old autoconf may be a problem but we can account for this with the usual '--help' check.
(In reply to Michał Górny from comment #2) > (In reply to Julian Ospald (hasufell) from comment #1) > > a problem is that we can probably not fix this without breaking a lot of > > stuff, can we? > > What stuff is going to be broken? I doubt many games actually use > datarootdir at all, not to mention using it incorrectly. > > Old autoconf may be a problem but we can account for this with the usual > '--help' check. Then do a tinderbox run. I will add this option locally to the eclass and do random testing.
Created attachment 365230 [details, diff] games.eclass.patch
it seems the only one that actually "broke" was games-roguelike/angband... but the data files were misplaced in /usr/games/share anyway, so I fixed it I did not test gnome games ebuilds, but afais they do their own econf thing anyway
Can someone from games team comment? I feel this is safe to apply.
I will apply this in two weeks unless someone has objections.
+ 25 Jan 2014; Julian Ospald <hasufell@gentoo.org> games.eclass: + set --datarootdir=/usr/share wrt #493954 +
