Hello. ruby-openid was updated to version 2.3.0 for quite some time now. Alongside test fixes and deprecation of ruby 1.8 one of the notable changes is a proper Google OpenID support (see [0]). Please bump. [0]: https://github.com/openid/ruby-openid/pull/53 Reproducible: Always
Unfortunately ruby-openid-2.3.0 fails its test suite and this has not been investigated yet due to lack of time.
Created attachment 367572 [details, diff] ruby-openid-2.3.0.patch Hans, could you review this patch? I think tests failed for you since configuration was added in the wrong place... At least now tests work for me.
(In reply to Peter Volkov from comment #2) > Created attachment 367572 [details, diff] [details, diff] > ruby-openid-2.3.0.patch > > Hans, could you review this patch? I think tests failed for you since > configuration was added in the wrong place... At least now tests work for me. This change is correct, but I still get test failures with it. Failure: Exception raised: ArgumentError(<invalid byte sequence in UTF-8>) test_linkparse(LinkParseTestCase) /var/tmp/portage/dev-ruby/ruby-openid-2.3.0/work/ruby19/ruby-openid-2.3.0/test/test_linkparse.rb:108:in `test_linkparse' 105: else 106: html = "<html><body>hello joel\255</body></html>" 107: end => 108: assert_nothing_raised do 109: OpenID::parse_link_attrs(html) 110: end 111: ================================================================================================================================== ....................................................................................................F ================================================================================================================================== Failure: <false> is not true. test_no_assoc_handle(OpenID::Consumer::CheckIDRequest::TestCheckIDRequestOpenID2) /var/tmp/portage/dev-ruby/ruby-openid-2.3.0/work/ruby19/ruby-openid-2.3.0/test/test_checkid_request.rb:56:in `assert_openid_key_absent' /var/tmp/portage/dev-ruby/ruby-openid-2.3.0/work/ruby19/ruby-openid-2.3.0/test/test_checkid_request.rb:206:in `test_no_assoc_handle' 203: msg = assert_log_matches("Generated checkid") { 204: @checkid_req.get_message(@realm, @return_to, immediate) 205: } => 206: assert_openid_key_absent(msg, 'assoc_handle') 207: end 208: end 209:
ruby-openid-2.5.0 was released. Test suite works for ruby19, ruby20 but fails for jruby: 1) Error: test_sign_sha1(OpenID::AssociationTestCase): NoMethodError: undefined method `force_encoding' for #<String:0x1ce9d39c> 2) Error: test_strxor_success(OpenID::DiffieHellmanTestCase): NoMethodError: undefined method `force_encoding' for "\000":String
(In reply to Manuel Rüger from comment #4) > ruby-openid-2.5.0 was released. Test suite works for ruby19, ruby20 but > fails for jruby: > > > 1) Error: > test_sign_sha1(OpenID::AssociationTestCase): > NoMethodError: undefined method `force_encoding' for #<String:0x1ce9d39c> > > > 2) Error: > test_strxor_success(OpenID::DiffieHellmanTestCase): > NoMethodError: undefined method `force_encoding' for "\000":String Looks like ruby 1.8 incompatibility, and our current jruby 1.6 still defaults to the ruby 1.8 profile. This should be fixed with jruby 1.7 when we get it in the tree, but until that time I guess we also need to drop jruby support.
I've dropped jruby and ruby18 from ruby-openid as only rack-openid, redmine, chef-server-webui depend on it. chef-server-webui is ruby19 only. So we'll just need to drop redmine's an rack-openid's ruby18 target.
ruby-openid-2.5.0 is in tree.
