Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 491190 - x11-libx/mx is missing an "nls" enabled check
Summary: x11-libx/mx is missing an "nls" enabled check
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
: 491180 491204 491212 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-11-13 20:23 UTC by Seemant Kulleen
Modified: 2014-02-19 06:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Add an "nls" USE check. (mx-1.4.7.diff,909 bytes, patch)
2013-11-13 20:23 UTC, Seemant Kulleen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Seemant Kulleen 2013-11-13 20:23:08 UTC
Created attachment 363210 [details, diff]
Add an "nls" USE check.

x11-libs/mx installs a whole bunch of translation files in /usr/share/locale because by default the configure script has --enable-nls.  The attached patch uses the "nls" USE flag to toggle that.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2014-02-18 23:42:19 UTC
As was noted in another bug report, USE=nls does not change build dependencies and only affects installed locales but we already have LINGUAS for that.

As it also causes no extra compile time (not sensible even back when I used pentium I/II/III) if LINGUAS is set appropriately, this falls under the current policy that USE flags should not be used to control this like bash-completion, openrc init or systemd units.

I will copy that to our policy since I could not remember why we stopped doing this years ago.
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2014-02-19 04:26:59 UTC
Right. The "nls" USE flag might make sense for parts of @system that may end up being build on extremely old/extremely small systems, but definitely not for gnome.

However, it is good style for packages to respect the LINGUAS env variable to control which translations get installed, because people do get annoyed by translations for a hundred languages they will never use. Mx already respects LINGUAS as far as I can see, just like most other gnome packages, because its translation infrastructure is based on intltool. And ebuilds for packages that do not use intltool or equivalent can add explicit use-expand LINGUAS support using l10n.eclass.

If you find some package that doesn't respect LINGUAS, please file a bug about it and make it block #405485
Comment 3 Pacho Ramos gentoo-dev 2014-02-19 06:34:21 UTC
*** Bug 491212 has been marked as a duplicate of this bug. ***
Comment 4 Pacho Ramos gentoo-dev 2014-02-19 06:34:30 UTC
*** Bug 491204 has been marked as a duplicate of this bug. ***
Comment 5 Pacho Ramos gentoo-dev 2014-02-19 06:35:50 UTC
*** Bug 491180 has been marked as a duplicate of this bug. ***