Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 488626 - =xfce-extra/xfce4-taskmanager-1.0.0 - Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text()
Summary: =xfce-extra/xfce4-taskmanager-1.0.0 - Pango-WARNING **: Invalid UTF-8 string ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: ARM Linux
: Normal normal
Assignee: XFCE Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-10-19 17:51 UTC by Mikhail Kurinnoi
Modified: 2013-10-20 11:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
xfce4-taskmanager-Invalid_UTF-8_string.patch (xfce4-taskmanager-Invalid_UTF-8_string.patch,606 bytes, patch)
2013-10-19 17:52 UTC, Mikhail Kurinnoi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Kurinnoi 2013-10-19 17:51:46 UTC
xfce4-taskmanager-1.0.0 compiled fine, but after start, generate a lot if "(xfce4-taskmanager:32218): Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text()" warnings and take 100% CPU time on my ARM box.

Also found this issue in fedoraproject list:
https://lists.fedoraproject.org/pipermail/arm/2012-September/003988.html

Reproducible: Always




I did some investigation, and compiled code with all warnings enabled. One of warnings was connected to issue:

task-manager-linux.c: In function ‘get_task_cmdline’:
task-manager-linux.c:139:2: warning: comparison is always true due to limited range of data type [-Wtype-limits]

The problem was in line:

for (i = 0; (c = fgetc (file)) != EOF && i < (gint)sizeof (task->cmdline) - 1; i++)
where "c" - is char, and this is the point of issue.

I create patch and test it with epatch_user feature - work fine on amd64 and arm.
Comment 1 Mikhail Kurinnoi 2013-10-19 17:52:16 UTC
Created attachment 361344 [details, diff]
xfce4-taskmanager-Invalid_UTF-8_string.patch
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2013-10-19 19:18:33 UTC
This needs to be reported to http://bugzilla.xfce.org/ before it can be included in Portage (as per the policy we have with Xfce packages in tree)

Otherwise it turns into unmaintainable spagetti ;-)

Please do that if you have time. Thank you.
Comment 3 Mikhail Kurinnoi 2013-10-19 19:28:17 UTC
I fill the bug in xfce bugzilla too, hope, this help:
https://bugzilla.xfce.org/show_bug.cgi?id=10417
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2013-10-20 11:23:11 UTC
In portage as 1.0.0-r1