Bug 487272 – dev-util/eric-5.3.7 fails to start with external build of dev-python/coverage

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description errtee 2013-10-08 04:39:09 UTC]

asked the developer and he recommends not do delete the internal coverage module as in (excerpt from dev-util/eric-5.3.7.ebuild):

src_prepare() {
	# Avoid file collisions between different slots of Eric.
	sed -e "s/^Icon=eric$/&${SLOT}/" -i eric/${MY_PN}.desktop || die
	sed -e "s/\([^[:alnum:]]\)eric\.png\([^[:alnum:]]\)/\1eric5.png\2/" \
		-i $(grep -lr "eric\.png" .) || die
	mv eric/icons/default/eric{,5}.png || die
	mv eric/pixmaps/eric{,5}.png || die
	rm -f eric/APIs/Python/zope-*.api
	rm -f eric/APIs/Ruby/Ruby-*.api

	# Delete internal copies of dev-python/chardet,
	# dev-python/coverage and dev-python/pygments.
	rm -fr eric/ThirdParty
	rm -fr eric/DebugClients/Python{,3}/coverage
	sed -i -e '\|/coverage/|d' eric/${MY_PN}.e4p || die
	sed -i -e 's/from DebugClients\.Python3\?\.coverage /from coverage /' \
		$(grep -lr 'from DebugClients\.Python3\?\.coverage' .) || die

	# Fix desktop files (bug 458092).
	sed -i -e '/^Categories=/s:Python:X-&:' eric/eric5{,_webbrowser}.desktop || die
}

[Comment 1 Davide Pesavento (RETIRED) 2013-10-08 14:29:32 UTC]

(In reply to errtee from comment #0)
> asked the developer and he recommends not do delete the internal coverage
> module
> 

Has he provided any reasons? Does he apply any custom patches to the bundled copy?

[Comment 2 errtee 2013-10-10 04:09:25 UTC]

I think the problem is caused by these two lines in the ebuild:

	rm -fr eric/DebugClients/Python{,3}/coverage

sed -i -e '\|/coverage/|d' eric/${MY_PN}.e4p || die
	sed -i -e 's/from DebugClients\.Python3\?\.coverage /from coverage /' \
		$(grep -lr 'from DebugClients\.Python3\?\.coverage' .) || die

the latter simply doesn't substitute as intended (and the module has been deleted in the first line)

you don't need that because the developer provides his own version of the python coverage module in the tree of his source code (for whatever reasons)

[Comment 3 Davide Pesavento (RETIRED) 2013-10-14 12:45:17 UTC]

(In reply to errtee from comment #2)
> you don't need that because the developer provides his own version of the
> python coverage module in the tree of his source code (for whatever reasons)

We have a policy against bundled libs [1]. I asked why upstream is shipping an internal copy of coverage, and "for whatever reasons" is not an acceptable answer, sorry.

[1] http://wiki.gentoo.org/wiki/Why_not_bundle_dependencies

[Comment 4 David Watzke 2013-10-23 06:44:04 UTC]

I've fixed this for myself by:

1) modifying /usr/lib64/python3.2/site-packages/eric5/DataViews/PyCoverageDialog.py on line 22

- from DebugClients.Python3.coverage.misc import CoverageException
+ from coverage.misc import CoverageException

(the problem is that the sed in the ebuild is incorrect imho, as Python3\?\.coverage won't match Python3.coverage)

2) there's also a dependency bug - after doing 1) it showed me another error that it can't find sqlite3 module. After remerging the relevant python version with USE=sqlite it now works fine. So there should be a dep on that useflag.

[Comment 5 errtee 2013-10-23 12:27:29 UTC]

That's exactly what I did. So if someone could fix this sed statement everything would be fine

[Comment 6 Davide Pesavento (RETIRED) 2013-11-24 22:50:57 UTC]

Should be fixed in 5.3.8

[Comment 7 Davide Pesavento (RETIRED) 2014-08-20 18:37:23 UTC]

*** Bug 501084 has been marked as a duplicate of this bug. ***