Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 487026 - git-r3 does not set any build-time deps
Summary: git-r3 does not set any build-time deps
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-05 16:18 UTC by Julian Ospald
Modified: 2013-10-08 11:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
git-r3.patch (git-r3.patch,460 bytes, patch)
2013-10-07 05:55 UTC, William Hubbs
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2013-10-05 16:18:29 UTC
>>> Emerging (1 of 1) app-vim/youcompleteme-99999999
>>> Unpacking source...
 * Fetching HEAD from git://github.com/Valloric/YouCompleteMe.git ...
/var/tmp/portage/app-vim/youcompleteme-99999999/temp/environment: line 2528: git: command not found


it seems all ebuilds currently using git-r3 are affected
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-05 16:48:34 UTC
/var/cvsroot/gentoo-x86/eclass/git-r3.eclass,v  <--  git-r3.eclass
new revision: 1.13; previous revision: 1.12

Added.
Comment 2 Bertrand Jacquin 2013-10-06 18:22:47 UTC
This break stable ARCH as there is no >=dev-vcs/git-1.8.2.1 stable.

Last stable is 1.8.1.5
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-06 18:30:52 UTC
(In reply to Bertrand Jacquin from comment #2)
> This break stable ARCH as there is no >=dev-vcs/git-1.8.2.1 stable.
> 
> Last stable is 1.8.1.5

And which package using this eclass is stable? If you mix stable with non-stable, you have to be able to handle the fallout.
Comment 4 Bertrand Jacquin 2013-10-06 18:32:48 UTC
(In reply to Michał Górny from comment #3)
> (In reply to Bertrand Jacquin from comment #2)
> > This break stable ARCH as there is no >=dev-vcs/git-1.8.2.1 stable.
> > 
> > Last stable is 1.8.1.5
> 
> And which package using this eclass is stable? If you mix stable with
> non-stable, you have to be able to handle the fallout.

true :) Sorry for noise
Comment 5 Julian Ospald 2013-10-06 18:34:20 UTC
(In reply to Bertrand Jacquin from comment #4)
> (In reply to Michał Górny from comment #3)
> > (In reply to Bertrand Jacquin from comment #2)
> > > This break stable ARCH as there is no >=dev-vcs/git-1.8.2.1 stable.
> > > 
> > > Last stable is 1.8.1.5
> > 
> > And which package using this eclass is stable? If you mix stable with
> > non-stable, you have to be able to handle the fallout.
> 
> true :) Sorry for noise

It is not true. There is no policy that says that we should ignore the possibility that 9999 packages can be installed on stable arch.

This is just, because the maintainer of the eclass didn't think of it in the first place and now doesn't care to fix.
Comment 6 Julian Ospald 2013-10-06 20:05:26 UTC
but anyway... unmasking latest git should really be fine.
Comment 7 William Hubbs gentoo-dev 2013-10-07 05:47:00 UTC
I just got bit by this. I shouldn't be forced to use ~arch git because I
am using live ebuilds when the git eclass doesn't depend on features in
~arch git.

Please adjust the dependency.

Thanks,

William
Comment 8 William Hubbs gentoo-dev 2013-10-07 05:55:58 UTC
Created attachment 360284 [details, diff]
git-r3.patch

This patch will fix the issue.

Thanks,

William
Comment 9 Julian Ospald 2013-10-07 11:08:28 UTC
(In reply to William Hubbs from comment #8)
> Created attachment 360284 [details, diff] [details, diff]
> git-r3.patch
> 
> This patch will fix the issue.
> 
> Thanks,
> 
> William

That will not work consistently, see bug 487018
Comment 10 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-07 13:49:31 UTC
(In reply to William Hubbs from comment #7)
> I just got bit by this. I shouldn't be forced to use ~arch git because I
> am using live ebuilds when the git eclass doesn't depend on features in
> ~arch git.
> 
> Please adjust the dependency.

It requires --unshallow that is not available 1.8.1.5.
Comment 11 William Hubbs gentoo-dev 2013-10-07 14:57:41 UTC
(In reply to Michał Górny from comment #10)
> (In reply to William Hubbs from comment #7)
> > I just got bit by this. I shouldn't be forced to use ~arch git because I
> > am using live ebuilds when the git eclass doesn't depend on features in
> > ~arch git.
> > 
> > Please adjust the dependency.
> 
> It requires --unshallow that is not available 1.8.1.5.

Are you sure it requires this? It hasn't seened to cause issues here with latest stable git.
Comment 12 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-07 15:07:04 UTC
Yes. This happens e.g. when you use the same repo as EGIT_REPO_URI for one package, and a submodule for another one. Or when you disable shallow clones at some point.
Comment 13 William Hubbs gentoo-dev 2013-10-07 15:55:37 UTC
Ok, that's all I needed to know. :-)
Comment 14 Mina Naguib 2013-10-07 22:09:44 UTC
FWIW the git-2 eclass includes this tidbit:

    # (since we override src_unpack this doesn't hurt)
    inherit git-r3

And we know that from the above discussion that git-r3 depends on >=dev-vcs/git-1.8.2.1, for which no versions are marked as stable.

This means that any ebuilds which currently inherit git-2 (stable, or not) will force the user to unmask dev-vcs/git to proceed.
Comment 15 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-08 11:20:17 UTC
(In reply to Mina Naguib from comment #14)
> FWIW the git-2 eclass includes this tidbit:
> 
>     # (since we override src_unpack this doesn't hurt)
>     inherit git-r3

Fixed this one. Now git-r3 should require the new git only.