Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 486564 - sys-apps/memtest86+-5.01: version bump
Summary: sys-apps/memtest86+-5.01: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: EBUILD
: 523460 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-09-30 10:57 UTC by Maks
Modified: 2015-01-31 23:01 UTC (History)
13 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
New version ebuild (memtest86+-5.01.ebuild,2.10 KB, text/plain)
2013-09-30 10:59 UTC, Maks
Details
Diff -u memtest86+ 4.20-r1 and 5.01 (memtest86+.diff,494 bytes, patch)
2013-09-30 12:51 UTC, Maks
Details | Diff
Fixes build with gcc 4.7.3-r1 (memtest86+-5.01-recent_gcc_compat.patch,2.33 KB, patch)
2014-06-22 15:13 UTC, Alexander
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maks 2013-09-30 10:57:27 UTC
See homepage for the new version. Maybe only changed name of ebuild is needed.

Reproducible: Always
Comment 1 Maks 2013-09-30 10:59:39 UTC
Created attachment 359784 [details]
New version ebuild
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2013-09-30 11:13:54 UTC
Please attach unified diffs (diff -u) when you did changes to an ebuild. That would be much more handy for us.
Comment 3 Maks 2013-09-30 12:51:46 UTC
Created attachment 359788 [details, diff]
Diff -u memtest86+ 4.20-r1 and 5.01
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2013-10-17 22:18:42 UTC
Seems like memtest86+-5.01 crashes with recent gcc versions:

http://forum.canardpc.com/threads/83443-Memtest86-V5.01-crashes-with-gcc-4.7.2-or-later

Since we stabilized gcc-4.7.3 recently I won't bump memtest86+ to this version unless there's a patch available.
Comment 5 Alexander 2014-06-22 15:13:06 UTC
Created attachment 379408 [details, diff]
Fixes build with gcc 4.7.3-r1

This patch does three things:
1) removes optimizations 
2) fixes variables that should have been set to static
3) fixes array upper limit in for loops used to scan PCI devices.

Its meant to be applied after the scp command is removed from the "make all" option; see the sed magic from the previously attached patch here: https://486564.bugs.gentoo.org/attachment.cgi?id=359788

I've taken the array fix from the Fedora package of memtest86+ (not sure if that matters?). Also forgive me if anything is off color, this is one of my first patches. :-D
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2014-09-22 16:18:22 UTC
*** Bug 523460 has been marked as a duplicate of this bug. ***
Comment 7 Andrew Savchenko gentoo-dev 2014-10-07 10:32:13 UTC
With patch proposed above 5.0.1 works fine after compilation with gcc-4.8.3.
Comment 8 Nikos Chantziaras 2015-01-03 20:42:55 UTC
Ping.
Comment 9 Andrew Savchenko gentoo-dev 2015-01-30 21:14:55 UTC
Dear base team, I'm going to add 5.0.1 in tree (with the patch above) it two weeks if there are no objections.

This bug is pending now for too long and people are in high demand of this tool.
Comment 10 Tony Vroon (RETIRED) gentoo-dev 2015-01-31 16:16:36 UTC
Please proceed now Andrew, the concerns that Lars had look to have been addressed. Any further issues can be dealt with in new bugs. Sorry for the delay.
Comment 11 Andrew Savchenko gentoo-dev 2015-01-31 23:01:03 UTC
In tree now. Aside from gcc-4.7.3 patch I ported patch to remove hardcoded CC/AS and added QA_FLAGS_IGNORED, since we don't allow users to change CFLAGS anyway.