Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 485458 - repoman manifest leaves incomplete download after error
Summary: repoman manifest leaves incomplete download after error
Status: RESOLVED DUPLICATE of bug 175612
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-20 03:52 UTC by Paweł Hajdan, Jr. (RETIRED)
Modified: 2019-04-22 06:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2013-09-20 03:52:24 UTC 
I was running repoman manifest for new www-client/chromium ebuild. Here's the result:

>>> Downloading 'https://commondatastorage.googleapis.com/chromium-browser-official/chromium-31.0.1626.0-testdata.tar.xz'
--2013-09-20 05:09:31--  https://commondatastorage.googleapis.com/chromium-browser-official/chromium-31.0.1626.0-testdata.tar.xz
Resolving commondatastorage.googleapis.com... 74.125.239.42, 74.125.239.44, 74.125.239.43
Connecting to commondatastorage.googleapis.com|74.125.239.42|:443... connected.
HTTP request sent, awaiting response... Read error (Success.) in headers.
Retrying.

--2013-09-20 05:10:33--  (try: 2)  https://commondatastorage.googleapis.com/chromium-browser-official/chromium-31.0.1626.0-testdata.tar.xz
Connecting to commondatastorage.googleapis.com|74.125.239.42|:443... connected.
HTTP request sent, awaiting response... Read error (Success.) in headers.
Retrying.

--2013-09-20 05:11:35--  (try: 3)  https://commondatastorage.googleapis.com/chromium-browser-official/chromium-31.0.1626.0-testdata.tar.xz
Connecting to commondatastorage.googleapis.com|74.125.239.42|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 108886432 (104M) [binary/octet-stream]
Saving to: '/usr/portage/distfiles/chromium-31.0.1626.0-testdata.tar.xz'

 0% [                                                                     ] 1,048,576   --.-K/s   in 85s     

2013-09-20 05:13:03 (12.0 KB/s) - Read error at byte 1048576/108886432 (The specified session has been invalidated for some reason.). Giving up.

No digest file available and download failed.

!!! Couldn't download 'chromium-31.0.1626.0-testdata.tar.xz'. Aborting.
 * The following are listed in SRC_URI for chromium:
 *    https://commondatastorage.googleapis.com/chromium-browser-official/chromium-31.0.1626.0.tar.xz
 *    test?
 *    (
 *    https://commondatastorage.googleapis.com/chromium-browser-official/chromium-31.0.1626.0-testdata.tar.xz
 *    )
!!! Fetch failed for chromium-31.0.1626.0-testdata.tar.xz, can't update Manifest
Unable to generate manifest.

 * Messages for package www-client/chromium-31.0.1626.0:

 * The following are listed in SRC_URI for chromium:
 *    https://commondatastorage.googleapis.com/chromium-browser-official/chromium-31.0.1626.0.tar.xz
 *    test?
 *    (
 *    https://commondatastorage.googleapis.com/chromium-browser-official/chromium-31.0.1626.0-testdata.tar.xz
 *    )

But the incomplete chromium-31.0.1626.0-testdata.tar.xz file was actually still left in /usr/portage/distfiles .

Shouldn't portage download to a temporary directory / under temporary file name first, and only rename to target name after successful fetch?
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-04-21 12:14:35 UTC 
Ping.
Comment 2 Zac Medico gentoo-dev 2019-04-22 06:07:42 UTC 

*** This bug has been marked as a duplicate of bug 175612 ***
Comment 3 Zac Medico gentoo-dev 2019-04-22 06:20:48 UTC 
(In reply to Michał Górny from comment #1)
> Ping.

This will be solved by by the fix for bug 175612, using a temporary download file with a constant suffix, and atomic rename after the download is complete.