Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 484954 - dev-python/dnspython(3?)-1.11.1 (version bump?) / add python3 support
Summary: dev-python/dnspython(3?)-1.11.1 (version bump?) / add python3 support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-15 01:34 UTC by Anton Bolshakov
Modified: 2015-11-02 02:29 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-python/dnspython-1.11.1-r1 ebuild proposal (dnspython-1.11.1-r1.ebuild,1.59 KB, text/plain)
2014-12-24 14:34 UTC, Vincent-Xavier JUMEL
Details
dev-python/dnspython-1.12.0-r1 ebuild proposal (dnspython-1.12.0-r1.ebuild,1.52 KB, text/plain)
2014-12-24 14:35 UTC, Vincent-Xavier JUMEL
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Bolshakov 2013-09-15 01:34:53 UTC
Please python3 support. The source code is available from:
http://www.dnspython.org/kits3/
Comment 1 Dirkjan Ochtman (RETIRED) gentoo-dev 2014-06-17 11:40:16 UTC
The way they're doing this is just way annoying.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-06-17 14:28:59 UTC
Well, it seems that they release in sync, so we could possibly set up a single ebuild with two tarballs.
Comment 3 Leho Kraav (:macmaN @lkraav) 2014-10-11 14:29:47 UTC
net-im/err-2.1.0 bump would benefit from this.
Comment 4 Vincent-Xavier JUMEL 2014-12-24 14:32:56 UTC
Hello,

I've spend a bit of time, borrowing code from dev-python/unittest2 and I've got this package : http://cgit.thetys-retz.net/overlay/tree/dev-python/dnspython

If any of you want to review this code, I may also attach to the bug report.

Happy GNU Year ;-)
Comment 5 Vincent-Xavier JUMEL 2014-12-24 14:34:35 UTC
Created attachment 392324 [details]
dev-python/dnspython-1.11.1-r1 ebuild proposal
Comment 6 Vincent-Xavier JUMEL 2014-12-24 14:35:05 UTC
Created attachment 392326 [details]
dev-python/dnspython-1.12.0-r1 ebuild proposal
Comment 7 Vincent-Xavier JUMEL 2014-12-24 14:36:07 UTC
(In reply to Leho Kraav (:macmaN @lkraav) from comment #3)
> net-im/err-2.1.0 bump would benefit from this.

app-text/calibre may also benefit from this improvement !!!
Comment 8 Vincent-Xavier JUMEL 2014-12-24 14:40:42 UTC
Hmm, well, 
ebuild dnspython-1.11.1-r1.ebuild test fails, so this need a bit of work on the test part.
Comment 9 Manuel Rüger (RETIRED) gentoo-dev 2015-08-09 13:56:43 UTC
*dnspython-1.12.0-r1 (06 Mar 2015)

  06 Mar 2015; Ian Delaney <idella4@gentoo.org> +dnspython-1.12.0-r1.ebuild:
  revbump; add py3 support by addition of dnspython3 tarball, SRC_URI updated,
  virtual re-write, assistance from NP-Hardass in achieving final form of the
  ebuild
Comment 10 Daniel M. Weeks 2015-10-29 16:44:25 UTC
Unfortunately, I just tested this ebuild and it installs the python 2 source for python 3 breaking use of dnspython in python 3. The problem appears during the prepare step where the python 2 version is copied into the python 3 WORKDIR.

Also, the python 2 sources are still fetched and unpacked even when PYTHON_TARGETS does not include python2_7. This combination means even without a python 2 target the install is broken.
Comment 11 Daniel M. Weeks 2015-10-29 16:55:59 UTC
I'm not very familiar with the distutils-r1 eclass but as far as I can tell the prepare_all fires first, performing the copy that causes the problem. Then the version-specific prepare phases are run which are essentially nops.
Comment 12 Justin Lecher (RETIRED) gentoo-dev 2015-10-30 12:06:38 UTC
(In reply to Daniel M. Weeks from comment #11)
> I'm not very familiar with the distutils-r1 eclass but as far as I can tell
> the prepare_all fires first, performing the copy that causes the problem.
> Then the version-specific prepare phases are run which are essentially nops.

The way it was implemented simply doesn't work. Should be working now.

commit 455634fa7080a3aa5437871558552d722efbfe70
Author: Justin Lecher <jlec@gentoo.org>
Date:   Fri Oct 30 11:05:55 2015 +0100
    
    dev-python/dnspython: Conver to py ABI slotted ebuilds
    
    Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=484954
    
    Package-Manager: portage-2.2.23
    Signed-off-by: Justin Lecher <jlec@gentoo.org>
    
    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=455634fa7080a3aa5437871558552d722efbfe70
Comment 13 Anton Bolshakov 2015-11-01 04:58:28 UTC
(In reply to Justin Lecher from comment #12)
> The way it was implemented simply doesn't work. Should be working now.

the usual dev-python/dnspython[${PYTHON_USEDEP}] is broken now.

Is it possible to normalize it to that format? I was thinking about creating a virtual ebuild, but it might be an overkill
Comment 14 Anton Bolshakov 2015-11-01 05:29:36 UTC
fyi, I came up with the following workaround for now:

-	dev-python/dnspython[${PYTHON_USEDEP}]
+	!dev-python/dnspython:0
+	$(python_gen_useflags 'python2*')? ( dev-python/dnspython:py2 )
+	$(python_gen_useflags 'python3*')? ( dev-python/dnspython:py3 )
Comment 15 Justin Lecher (RETIRED) gentoo-dev 2015-11-01 06:49:19 UTC
(In reply to Anton Bolshakov from comment #13)
> (In reply to Justin Lecher from comment #12)
> > The way it was implemented simply doesn't work. Should be working now.
> 
> the usual dev-python/dnspython[${PYTHON_USEDEP}] is broken now.
> 
> Is it possible to normalize it to that format? I was thinking about creating
> a virtual ebuild, but it might be an overkill

You need to use the virtual now. I anything broken with it?
Comment 16 Anton Bolshakov 2015-11-02 02:29:19 UTC
oh, there is a new "virtual/dnspython" ebuild. Ok, that will do it.

It is not listed in your commit.

Thanks!