Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 484424 - games-fps/doomsday: relies on python wrapping internals
Summary: games-fps/doomsday: relies on python wrapping internals
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 484398
  Show dependency tree
 
Reported: 2013-09-09 21:49 UTC by Michał Górny
Modified: 2014-09-01 07:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-09-09 21:49:39 UTC
#...
            python_replicate_script "${D}"/"${GAMES_BINDIR}"/launch-doomsday

            installmodules() {
                # relocate snowberry module directory recursively into site-packages
                python_domodule "${D}/${GAMES_DATADIR}"/${PN}/snowberry
                # hack around improper path handling
                sed -i \
                    -e "s:os.chdir.*$:os.chdir('$(python_get_sitedir)/snowberry'):" \
                    "${D}"/"${GAMES_BINDIR}"/launch-doomsday-${EPYTHON} || die
                                                            ^^^^^^^^^^^
            }
            python_foreach_impl installmodules


Not that any specific fix comes to my mind right now but please keep this open for reference.
Comment 1 Julian Ospald 2013-09-09 21:51:29 UTC
How is that a bug?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-09-09 22:00:50 UTC
(In reply to Julian Ospald (hasufell) from comment #1)
> How is that a bug?

It's touching internals. Things you aren't supposed to touch nor rely on. We're likely going to break it in a few days or weeks from now.
Comment 3 Julian Ospald 2013-09-09 22:04:44 UTC
What kind of internals? I don't use internal functions.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-09-09 22:12:21 UTC
You're making assumption about how will wrapping work. You're only guaranteed that 'launch-doomsday' will be accessible where you want it, and that it will respect implementation choices. You are not allowed to assume about location of wrapped scripts.
Comment 5 Julian Ospald 2013-09-09 22:33:09 UTC
If you mess with your API, you have to fix the consumers. If you break this package by eclass changes, I will revert it to the old python eclass.
Comment 6 Mike Gilbert gentoo-dev 2013-09-10 03:52:27 UTC
(In reply to Michał Górny from comment #4)

Instead of framing it as people doing something wrong and using eclass internals, you could simply state that the eclass behavior may change soon. No need to put people on the defensive.

End of the day, we are all just trying to make stuff work with the tools we are given.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-09-17 21:08:20 UTC
FYI: I've forced python-exec:0 in the ebuild now. We will probably revisit this near python-exec:2 going stable, so please keep the bug open.
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-09-01 07:59:42 UTC
Made it compatible with python-exec:2.