Bug 484412 – dev-python/root_numpy: plays with python wrapping internals (unnecessarily)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Michał Górny 2013-09-09 21:23:08 UTC]

python_test() {
    cd ${BUILD_DIR} || die
    nosetests-${EPYTHON} -v || die "Testing failed with ${EPYTHON}"
             ^^^^^^^^^^^
}


Please don't play with internals like this. 'nosetests' is a wrapper, and eclass sets up environment properly, so the wrapper will choose correct implementation.

[Comment 1 Michał Górny 2013-09-14 11:59:28 UTC]

Created attachment 358640 [details, diff]
patch to ebuild

Please let me know if this patch is ok to commit.

Changes:

1. enforced a single impl since sci-physics/root supports that only,

2. required USE=python on sci-physics/root,

3. fixed the nosetests invocation,

4. fixed EXAMPLES not to be compressed.

[Comment 2 Sébastien Fabbro (RETIRED) 2013-09-17 05:34:26 UTC]

(In reply to Michał Górny from comment #1)
> Created attachment 358640 [details, diff] [details, diff]
> patch to ebuild
> 
> Please let me know if this patch is ok to commit.

yes please do and feel free to do the same to all the other similar python bugs you filed

[Comment 3 Michał Górny 2013-09-17 07:33:58 UTC]

Committed.