Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 481296 - app-portage/pfl: use pfl command without /proc/sys/kernel/random/uuid
Summary: app-portage/pfl: use pfl command without /proc/sys/kernel/random/uuid
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Third-Party Tools (show other bugs)
Hardware: All FreeBSD
: Normal normal (vote)
Assignee: Daniel Pielmeier
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-08-16 12:42 UTC by Alice Ferrazzi
Modified: 2013-10-06 17:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pfl with no uuid work (pfl-no-uuid.patch,5.45 KB, patch)
2013-08-16 12:44 UTC, Alice Ferrazzi
Details | Diff
pfl without UUID (pfl.py,13.29 KB, text/plain)
2013-08-23 20:00 UTC, bugs
Details
2.4 ebuild (pfl-2.4.ebuild,1.08 KB, text/plain)
2013-10-02 11:22 UTC, bugs
Details
removed sed of python -O (pfl-2.4.ebuild,1.02 KB, text/plain)
2013-10-06 09:36 UTC, bugs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alice Ferrazzi Gentoo Infrastructure gentoo-dev 2013-08-16 12:42:21 UTC
I'm without uuid, so I have no folder /proc/sys/kernel/random/uuid but i still want to use pfl in my freebsd system.




Reproducible: Always

Steps to Reproduce:
1. don't use UUID
2.
3.
Actual Results:  
localhost ~ # pfl                                                    
Traceback (most recent call last):
  File "/usr/bin/pfl-python2.7", line 4, in <module>
    import pfl.pfl
  File "/usr/lib/python2.7/site-packages/pfl/pfl.py", line 515, in <module>
    pfl.do_job()
  File "/usr/lib/python2.7/site-packages/pfl/pfl.py", line 487, in do_job
    f = open(UUIDFILE, 'r')
IOError: [Errno 2] No such file or directory: '/proc/sys/kernel/random/uuid'

Expected Results:  
localhost ~ # pfl                                               
nothing to collect. If this is wrong, set PFL/lastrun in /var/lib/pfl/pfl.info to 0
Comment 1 Alice Ferrazzi Gentoo Infrastructure gentoo-dev 2013-08-16 12:44:25 UTC
Created attachment 356200 [details, diff]
pfl with no uuid work
Comment 2 bugs 2013-08-23 17:17:08 UTC
Hi,
FYI: I have seen this and I will fix this as soon as possible.

regards
Daniel
Comment 3 bugs 2013-08-23 20:00:38 UTC
Created attachment 356784 [details]
pfl without UUID

This is a new version of the PFL data collecting script without UUID.

The UUID was used to generate a unique identifiert to:
a) have unique names on server side after uploading
b) detect troubles on client level at server side

Now the upload process generates it's own unique names. Reason b) was never used by me. Also it is easy for "annoing users" to change the UUID on every run. Thus I decided that the UUID is useless and removed it. File names on client side get generated by tempfile.mkstemp().

@Alice Ferrazzi: Please test the new script and give us a feedback.
Comment 4 Alice Ferrazzi Gentoo Infrastructure gentoo-dev 2013-08-26 09:19:08 UTC
@Daniel: tested and working !
Comment 5 Daniel Pielmeier gentoo-dev 2013-09-09 07:50:57 UTC
(In reply to Daniel from comment #3)
> Created attachment 356784 [details]
> pfl without UUID
> 
> This is a new version of the PFL data collecting script without UUID.
> 
> The UUID was used to generate a unique identifiert to:
> a) have unique names on server side after uploading
> b) detect troubles on client level at server side
> 
> Now the upload process generates it's own unique names. Reason b) was never
> used by me. Also it is easy for "annoing users" to change the UUID on every
> run. Thus I decided that the UUID is useless and removed it. File names on
> client side get generated by tempfile.mkstemp().
> 
> @Alice Ferrazzi: Please test the new script and give us a feedback.

Daniel thanks for the new version. Is it possible to create a new version which includes the fix.
Comment 6 bugs 2013-10-02 11:22:27 UTC
Created attachment 359966 [details]
2.4 ebuild
Comment 7 bugs 2013-10-02 11:25:09 UTC
Hi,
I have finally created the version 2.4 which is available at http://files.portagefilelist.de/ .

Ebuild is attached.

regards
Daniel
Comment 8 bugs 2013-10-06 09:36:03 UTC
Created attachment 360206 [details]
removed sed of python -O

new pfl-2.4 ebuild without sed removal of python -O from the cron executable because the python -O command prefix was already removed in the tar.
Comment 9 Daniel Pielmeier gentoo-dev 2013-10-06 17:28:29 UTC
+*pfl-2.4 (06 Oct 2013)
+
+  06 Oct 2013; Daniel Pielmeier <billie@gentoo.org> +pfl-2.4.ebuild,
+  +files/e-file-20110906-portageq.patch:
+  Version bump. Fixes bug #420111, thanks to Jeroen Roovers for the patch.
+  Fixed bug #481296, thanks to Alice Ferrazzi for the report and Daniel for the
+  fix.