Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 481098 - wxwidgets eclass Prefix support
Summary: wxwidgets eclass Prefix support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Gentoo wxWidgets project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2013-08-14 21:07 UTC by Benda Xu
Modified: 2013-08-16 07:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
wxwidgets.patch (wxwidgets.patch,1.30 KB, patch)
2013-08-14 21:08 UTC, Benda Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benda Xu gentoo-dev 2013-08-14 21:07:00 UTC
Please review the trivial Prefix patches for wxwidgets eclass.

Reproducible: Always
Comment 1 Benda Xu gentoo-dev 2013-08-14 21:08:11 UTC
Created attachment 356042 [details, diff]
wxwidgets.patch
Comment 2 Ryan Hill (RETIRED) gentoo-dev 2013-08-15 04:03:10 UTC
Do ebuilds using the eclass need to be EAPI 3 or greater after this change?  

I'm thinking that wxGTK is EPREFIX aware and installs the wx-config scripts into ${EPREFIX}/usr/lib/wx/config/.  The eclass sets WX_CONFIG to whichever one.  But if the ebuild is EAPI < 3 then EPREFIX will be empty and WX_CONFIG will point to /usr/lib/wx/config/ instead where it's possible no configs exist.

Am I understanding that correctly?  Can you test games-util/wxchtdecoder and net-p2p/amule and see if they pass the prefixed wx-config path to configure?
Comment 3 Ryan Hill (RETIRED) gentoo-dev 2013-08-16 03:32:17 UTC
On second thought that shouldn't hold up this patch.  It does the right thing in almost all cases.  Go ahead and apply it.
Comment 4 Benda Xu gentoo-dev 2013-08-16 07:53:47 UTC
Commited. I don't fully understand comment 2. I have my net-p2p/amule compiled against this eclass with no problem.

Ryan, thanks a lot for your help.

--- ChangeLog   2013-08-16 16:54:15.403568886 +0900
+++ ChangeLog.new       2013-08-16 16:54:28.159408523 +0900
@@ -2,6 +2,9 @@
 # Copyright 1999-2013 Gentoo Foundation; Distributed under the GPL v2
 # $Header: /var/cvsroot/gentoo-x86/eclass/ChangeLog,v 1.930 2013/08/15 15:36:26 kensington Exp $
 
+  16 Aug 2013; Benda Xu <heroxbd@gentoo.org> wxwidgets.eclass:
+  Prefix support for wxwidgets, bug #481093
+
   15 Aug 2013; Michael Palimaka <kensington@gentoo.org> kde4-base.eclass,
   kde4-meta.eclass:
   Fixes for KDE 4.11 and other small improvements.