Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 479744 - qt4-r2.eclass: split into qmake-utils.eclass
Summary: qt4-r2.eclass: split into qmake-utils.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Qt Bug Alias
URL: http://git.overlays.gentoo.org/gitweb...
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2013-08-04 19:36 UTC by Julian Ospald
Modified: 2013-12-24 02:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2013-08-04 19:36:55 UTC
eqmake4 should be split into a utility eclass

The current design of qt4-r2 causes random phase overrides and uses base.eclass by default which many devs do not like at all. Some eclasses are already dropping base.eclass inherit to favor the PMS specified behavior.

Currently I am overriding all such phases I don't want being overridden by base.eclas, as in:

src_unpack() { default; }

that *****. The only reason I use qt4-r2 is because of the eqmake4 function, please split it (probably along with the "_find_project_file" function).
Comment 1 Sergey Popov gentoo-dev 2013-08-05 06:15:58 UTC
@pesa, what do you think? IIRC, you did such split in qt overlay. Is it ready to hit main tree?
Comment 2 Davide Pesavento gentoo-dev 2013-08-05 06:31:59 UTC
We are already working towards this, see qmake-utils.eclass in qt overlay (contains both eqmake4 and eqmake5). We could move it to the main tree I think, reviews are appreciated.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2013-08-05 10:38:29 UTC
Will we keep the eqmake code in both eclasses, or have qt4-r2 inherit qmake-utils?
Comment 4 Julian Ospald 2013-08-05 10:46:52 UTC
(In reply to Michael Palimaka (kensington) from comment #3)
> Will we keep the eqmake code in both eclasses, or have qt4-r2 inherit
> qmake-utils?

code duplication is not good
Comment 5 Michael Palimaka (kensington) gentoo-dev 2013-08-05 10:49:59 UTC
(In reply to Julian Ospald (hasufell) from comment #4)
> (In reply to Michael Palimaka (kensington) from comment #3)
> > Will we keep the eqmake code in both eclasses, or have qt4-r2 inherit
> > qmake-utils?
> 
> code duplication is not good

I know, but it never hurts to explore all options, someone may think of an issue others did not.
Comment 6 Sergey Popov gentoo-dev 2013-08-05 11:01:41 UTC
(In reply to Michael Palimaka (kensington) from comment #3)
> Will we keep the eqmake code in both eclasses, or have qt4-r2 inherit
> qmake-utils?

I think about the latter. The first seems strange to me
Comment 7 Davide Pesavento gentoo-dev 2013-08-05 15:03:28 UTC
(In reply to Michael Palimaka (kensington) from comment #3)
> Will we keep the eqmake code in both eclasses, or have qt4-r2 inherit
> qmake-utils?

I'm more inclined towards the latter, although that would mean exposing eqmake5() to qt4-r2 consumers...
Comment 8 Julian Ospald 2013-09-25 13:24:13 UTC
how is it going?
Comment 9 Davide Pesavento gentoo-dev 2013-09-25 13:35:39 UTC
I will take care of this as soon as I get back from my devaway (2nd half of October hopefully)
Comment 10 Davide Pesavento gentoo-dev 2013-12-02 12:31:27 UTC
qmake-utils.eclass is now in tree (thanks pinkbyte!)
Comment 11 Julian Ospald 2013-12-02 15:14:17 UTC
thanks