Bug 479436 – marisa: Matching Algorithm with Recursively Implemented StorAge

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Rafał Mużyło 2013-08-01 20:51:45 UTC]

This package will be needed for libkkc (IME backend).

Basic ebuild is trivial (autotools), but it gets tricky when it comes to bindings (perl, python, ruby).

The bindings themselves are swig-based, but the problem comes from build system.
Not only it's not integrated with the rest of the build, but it sort of expects the lib to be already installed, cause it doesn't pass the paths to uninstalled includes/libs.

[Comment 1 Rafał Mużyło 2013-08-02 17:54:55 UTC]

Created attachment 354964 [details]
WIP: ebuild for the lib (only python module atm)

A bit crude but builds enough for libkkc-data.
The way I've done it forces swig dependency, even though swig generated files are in the tarball.

I'm not sure what's the policy on swig files.

[Comment 2 Rafał Mużyło 2013-08-02 17:55:41 UTC]

Created attachment 354966 [details, diff]
python patch used in the ebuild

[Comment 3 Naohiro Aota 2013-12-01 10:21:04 UTC]

Comment on attachment 354964 [details]
WIP: ebuild for the lib (only python module atm)

>EAPI=5

Please include copyright notice and license.

>PYTHON_COMPAT=( python{2_7,3_3} )
>DISTUTILS_OPTIONAL=1
>
>inherit distutils-r1 perl-module eutils
>
>DESCRIPTION="Matching Algorithm with Recursively Implemented StorAge"
>HOMEPAGE=""

HOMEPAGE could be "https://code.google.com/p/marisa-trie/"?

>DEPEND="
>	perl? ( dev-lang/swig )
>	python? ( dev-lang/swig )
>	ruby? ( dev-lang/swig )"

If you enable DISTUTILS_OPTIONAL, you have to set proper dependencies for your package (using ${PYTHON_DEPS})

>src_install() {
>	emake DESTDIR="${D}" install

You can use "${ED}" instead of "${D}"

[Comment 4 Rafał Mużyło 2014-01-19 00:34:40 UTC]

(In reply to Naohiro Aota from comment #3)
> Comment on attachment 354964 [details]
> WIP: ebuild for the lib (only python module atm)
> 
> >EAPI=5
> 
> Please include copyright notice and license.
> 
I really don't mind.

> >DESCRIPTION="Matching Algorithm with Recursively Implemented StorAge"
> >HOMEPAGE=""
> 
> HOMEPAGE could be "https://code.google.com/p/marisa-trie/"?
> 
That seems correct.

> >DEPEND="
> >	perl? ( dev-lang/swig )
> >	python? ( dev-lang/swig )
> >	ruby? ( dev-lang/swig )"
> 
> If you enable DISTUTILS_OPTIONAL, you have to set proper dependencies for
> your package (using ${PYTHON_DEPS})
>
Right - not used to working with that eclass.

> >src_install() {
> >	emake DESTDIR="${D}" install
> 
> You can use "${ED}" instead of "${D}"
No real experience with prefix - not sure when $Efoo needed instead of $foo.

[Comment 5 Yixun Lan 2014-08-18 03:37:11 UTC]

Created attachment 383064 [details]
marisa-0.2.4.ebuild

1) revised version based on rafal's work, please review
2) current I've removed perl/ruby support, cause I've not tested (can't)

I'll commit in a few days if no objection.

[Comment 6 Yixun Lan 2014-08-18 03:37:32 UTC]

Created attachment 383066 [details]
metadata.xml

[Comment 7 Yixun Lan 2014-08-22 02:47:40 UTC]

+*marisa-0.2.4 (22 Aug 2014)
+
+  22 Aug 2014; Yixun Lan <[e-mail]> +marisa-0.2.4.ebuild,
+  +files/marisa-0.2.4-python.patch, +metadata.xml:
+  initial version added, bug 479436


oops, I forgot to add the "thanks Rafal Muzylo" to the commit log..

[Comment 8 Rafał Mużyło 2014-08-22 14:44:33 UTC]

(In reply to Yixun Lan from comment #7)
> 
> oops, I forgot to add the "thanks Rafal Muzylo" to the commit log..

I don't mind that.
What I do mind, is that those are distinct letters, not just letters with accent marks.