Bug 479392 – media-video/qx11grab needs a patch for ffmpeg-2

• Status: RESOLVED TEST-REQUEST
• Product: Gentoo Linux

[Description Helmut Jarausch 2013-08-01 12:05:52 UTC]

Created attachment 354812 [details, diff]
patch for ffmpeg-2

The attached patch should probably applied for ffmpeg-2 only

[Comment 1 Michael Palimaka (kensington) 2013-08-06 10:53:46 UTC]

We can't really apply the patch only when the user has ffmpeg-2 installed.

Upstream has been responsive in the past, so we could try sending them a backwards-compatible patch.

[Comment 2 Alexis Ballier 2013-08-07 13:09:59 UTC]

(In reply to Michael Palimaka (kensington) from comment #1)
> We can't really apply the patch only when the user has ffmpeg-2 installed.
> 
> Upstream has been responsive in the past, so we could try sending them a
> backwards-compatible patch.

AVCodecID should be in ffmpeg 1.0 and libav-9 iirc, that is, the providers of virtual/ffmpeg-9 that it currently depends on, so backward compat isnt really an issue i think

[Comment 3 Michael Palimaka (kensington) 2013-08-07 13:17:46 UTC]

(In reply to Alexis Ballier from comment #2)
> AVCodecID should be in ffmpeg 1.0 and libav-9 iirc, that is, the providers
> of virtual/ffmpeg-9 that it currently depends on, so backward compat isnt
> really an issue i think

If you think it's fine, feel free to apply. (is it suitable for upstream?)

[Comment 4 Alexis Ballier 2013-08-07 13:45:58 UTC]

s/CodecID/AVCodecID/ which the patch is about and s/CODEC_ID/AV_CODEC_ID/ which the patch doesnt do but should is good for upstream if they are ok with the ffmpeg 1.0/libav-9 requirement

[Comment 5 Davide Pesavento (RETIRED) 2013-10-02 00:22:46 UTC]

This was fixed upstream for 0.4.10, which I just added to the tree, but please test.