478336 – sys-apps/openrc: tmpfiles.sh signals an error if device nodes already exist

Bug 478336 - sys-apps/openrc: tmpfiles.sh signals an error if device nodes already exist

Summary: sys-apps/openrc: tmpfiles.sh signals an error if device nodes already exist

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Hosted Projects
Classification:	Unclassified
Component:	OpenRC (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	OpenRC Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	439098
	Show dependency tree

Reported:	2013-07-27 09:53 UTC by Dirk Sondermann
Modified:	2013-07-27 16:18 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch against openrc-0.11.8 (tmpfiles.sh.patch,615 bytes, patch) 2013-07-27 09:53 UTC, Dirk Sondermann	Details \| Diff
patch against git (tmpfiles.sh.patch,855 bytes, patch) 2013-07-27 09:57 UTC, Dirk Sondermann	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dirk Sondermann 2013-07-27 09:53:34 UTC

Created attachment 354296 [details, diff]
patch against openrc-0.11.8

When tmpfiles.sh is invoked by /etc/init.d/tmpfiles.setup and tries to create the device nodes requested by kmod (see bug 477856), it signals an error if some nodes already exist.

The reason for this error is that the functions _c and _d in tmpfiles.sh return the non-zero exit status of [ ! -e "$path" ] if the given path exists.

This problem may be avoided by replacing
   [ ! -e "$path" ] && ...
with
   if [ ! -e "$path" ]; then ...; fi

Comment 1 Dirk Sondermann 2013-07-27 09:57:19 UTC

Created attachment 354298 [details, diff]
patch against git

Comment 2 William Hubbs gentoo-dev

2013-07-27 16:17:49 UTC

This patch has been added in commit e90dcf3 and will be part of
OpenRc-0.12. Thanks for the report and patch.