Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 477674 - app-emulation/xen-tools-4.3.0 adds -Werror flag
Summary: app-emulation/xen-tools-4.3.0 adds -Werror flag
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Gentoo Xen Devs
Depends on:
Blocks: werror
  Show dependency tree
Reported: 2013-07-22 00:07 UTC by Julian Ospald
Modified: 2013-07-22 23:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

xen-tools-4.3.0:20130722-000248.log (xen-tools-4.3.0:20130722-000248.log,901.91 KB, patch)
2013-07-22 00:07 UTC, Julian Ospald
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Ospald 2013-07-22 00:07:37 UTC
Created attachment 353798 [details, diff]

package adds -Werror in some places
Comment 1 Ian Delaney (RETIRED) gentoo-dev 2013-07-22 11:26:18 UTC
Yes it does. This has been a bone of contention from the moment I started working xen around > 2 years ago. See files/xen-4-fix_dotconfig-gcc.patch.  unpack the source and start counting each and every instance where the upstream xensource makers elected to put it in.  xensource violates gentoo niceness in the build in a number of ways, this is but one.  Sure I can patch them all out, however 4.2 survived with the instances patched out by xen-4-fix_dotconfig-gcc.patch (which is a combo of 3 former sed statments).  The source built with those remnant Werror entries.  Is it a bug, or is it a state of reasonable compromise? You tell me.  I can keep patching them out, if REALLY need be.
Comment 2 Julian Ospald 2013-07-22 11:33:03 UTC

it's a QA violation, see the "-Werror compiler flag not removed" section and diegos blog post about werror rants
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2013-07-22 13:57:55 UTC
This is madness all over again. Do you know how big this patch is going to end up, not to mention the time to make it.  This is serving process, not any build failure.
Comment 4 Julian Ospald 2013-07-22 14:05:39 UTC
there are other ways to fix -Werror other than patching, read the devmanual guide
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2013-07-22 17:07:08 UTC
  22 Jul 2013; Ian Delaney <>
  files/xen-4.3-fix_dotconfig-gcc.patch, xen-tools-4.3.0.ebuild:
  Extend purging of Werror CFLAG in xen-4.3-fix_dotconfig-gcc.patch, fixes Bug