Bug 477318 – sys-apps/openrc-9999 commit 0f70cd06 fails to build due to unquoted RC_SVCNAME

• Status: RESOLVED FIXED
• Product: Gentoo Hosted Projects

[Description Duncan 2013-07-18 16:03:15 UTC]

Commit 0f70cd06 needs RC_SVCNAME quoted in unsetenv call.

This build log excerpt is actually from the next commit, 3af434, but I tested by setting openrc_LIVE_COMMIT= to get the bad commit, which has only one non-comment line... the line that errors out.  The other unsetenv calls in the file appear to have have a quoted string parameter, so the lack of quoting would seem to be the issue.

make[2]: Entering directory `/tmp/portage/sys-apps/openrc-9999/work/openrc-9999/src/rc'
echo "#define VERSION \"0.12git-3af434\"" >version.h.tmp
if test -n "Gentoo Linux"; then \
        echo "#define BRANDING \"Gentoo Linux\"" >> version.h.tmp; \
fi

[snip]

x86_64-pc-linux-gnu-gcc -march=native -pipe -O2 -frename-registers -fweb -fmerge-all-constants  -fgcse-sm -fgcse-las -fgcse-after-reload -ftree-vectorize -freorder-blocks-and-partition -std=c99 -Wall -Wextra -Wimplicit -Wshadow -Wformat=2 -Wmissing-prototypes -Wmissing-declarations -Wmissing-noreturn -Wmissing-format-attribute -Wnested-externs -Winline -Wwrite-strings -Wcast-align -Wcast-qual -Wpointer-arith -Wdeclaration-after-statement -Wsequence-point   -I../includes -I../librc -I../libeinfo -D_BSD_SOURCE -D_XOPEN_SOURCE=700  -DHAVE_TERMCAP -DHAVE_PAM -c rc-status.c -o rc-status.o

[snip]

rc-status.c: In function 'rc_status':
rc-status.c:356:12: error: 'RC_SVCNAME' undeclared (first use in this function)
rc-status.c:356:12: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [rc-status.o] Error 1
make[2]: Leaving directory `/tmp/portage/sys-apps/openrc-9999/work/openrc-9999/src/rc'

[Comment 1 Alexander Vershilov (RETIRED) 2013-07-18 16:17:50 UTC]

Sorry for that. Pull request with fix sent.

[Comment 2 William Hubbs 2013-07-19 20:34:08 UTC]

This is fixed in commit c18d623.
It will be in OpenRc-0.12.