Created attachment 353078 [details] build.log make[1]: Leaving directory `/var/tmp/portage/media-tv/xbmc-12.2-r1/work/xbmc-12.2/lib/libdvd' CPP xbmc/cores/dvdplayer/DVDAudio.o In file included from DVDAudio.cpp:23:0: DVDAudio.h:83:48: error: ‘CodecID’ has not been declared In file included from DVDMessage.h:33:0, from DVDMessageQueue.h:23, from DVDPlayerAudio.h:26, from DVDAudio.cpp:26: DVDDemuxers/DVDDemux.h:121:3: error: ‘CodecID’ does not name a type DVDDemuxers/DVDDemux.h: In constructor ‘CDemuxStream::CDemuxStream()’: DVDDemuxers/DVDDemux.h:91:5: error: ‘codec’ was not declared in this scope DVDDemuxers/DVDDemux.h:91:14: error: ‘CodecID’ was not declared in this scope DVDDemuxers/DVDDemux.h:91:22: error: expected ‘;’ before numeric constant In file included from DVDPlayerAudio.h:28:0, from DVDAudio.cpp:26: DVDStreamInfo.h: At global scope: DVDStreamInfo.h:62:3: error: ‘CodecID’ does not name a type In file included from DVDAudio.cpp:26:0: DVDPlayerAudio.h:41:6: error: use of enum ‘CodecID’ without previous declaration DVDAudio.cpp:119:57: error: ‘CodecID’ has not been declared make[1]: *** [DVDAudio.o] Error 1 make: *** [xbmc/cores/dvdplayer/DVDPlayer.a] Error 2 [31;01m*[0m ERROR: media-tv/xbmc-12.2-r1 failed (compile phase): [31;01m*[0m emake failed
Upstream bugs: http://trac.xbmc.org/ticket/14494 http://trac.xbmc.org/ticket/14275
FWIW: It is fixed in -9999, future xbmc-13. I do not think it will be backported to 12 since the patches are quite huge, maybe I'll do it later.
(In reply to Alexis Ballier from comment #2) > FWIW: It is fixed in -9999, future xbmc-13. I do not think it will be > backported to 12 since the patches are quite huge, maybe I'll do it later. XBMC 13 is at Release Candidate 1, guess it won't take much longer. Spotted in the post about it, I see this: - Update to FFMPEG v1.2 which we use for audio/video playback Are you sure they really support FFmpeg v2.x? As in, was it tested? Is a snapshot an option as this continues to block multiple security bugs?
(In reply to Tom Wijsman (TomWij) from comment #3) > (In reply to Alexis Ballier from comment #2) > > FWIW: It is fixed in -9999, future xbmc-13. I do not think it will be > > backported to 12 since the patches are quite huge, maybe I'll do it later. > > XBMC 13 is at Release Candidate 1, guess it won't take much longer. > > Spotted in the post about it, I see this: > > - Update to FFMPEG v1.2 which we use for audio/video playback > > Are you sure they really support FFmpeg v2.x? As in, was it tested? it used to work but xbmc 13 doesn't offer the option to use system libs so I guess we dont really care here > Is a snapshot an option as this continues to block multiple security bugs? dont treat those security bugs as confirmed unless someone has really looked at the code; I'm not really doing it anymore because I'm bored by ppl paid for publishing CVEs that do not do the appropriate checks: - some bugs say 'sec bugz in foo demuxer for ffmpeg < x.y' when foo demuxer was actually introduced in version x.y - some bugs say 'sec bug in blah, see commit abcd', where commit abcd is just when the fix appears in the ffmpeg history from libav merges while it was fixed a while ago in ffmpeg in the end, ffmpeg 1.2.6 or even 1.0.9 are likely to be unaffected by all these bugs... however, ffmpeg bundled in xbmc is 1.2(.0) if this has not changed, so this one likely has some bugs. hopefully they disable everything they don't need.
most likely a non-issue with 13.0+
