Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 475970 - media-libs/smpeg: please review prefix changes
Summary: media-libs/smpeg: please review prefix changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: Inclusion, PATCH
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2013-07-06 17:47 UTC by Christoph Junghans (RETIRED)
Modified: 2013-07-24 03:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch against smpeg-0.4.4-r9.ebuild (smpeg-0.4.4-r9.ebuild.patch,1007 bytes, patch)
2013-07-06 17:47 UTC, Christoph Junghans (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans (RETIRED) gentoo-dev 2013-07-06 17:47:45 UTC 
Created attachment 352730 [details, diff]
patch against smpeg-0.4.4-r9.ebuild

For full prefix support there is just one extra solaris tweak needed.
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2013-07-21 00:08:47 UTC 
looks like the patch is reversed?
Comment 2 Fabian Groffen gentoo-dev 2013-07-21 09:03:09 UTC 
obviously, yes
Comment 3 Christoph Junghans (RETIRED) gentoo-dev 2013-07-21 17:12:17 UTC 
(In reply to Mr. Bones. from comment #1)
> looks like the patch is reversed?
Yes, my mistake. Besides adding the keywords, there is only one tweak for Solaris.

+[[ ${CHOST} == *-solaris* ]] && append-libs -lnsl -lsocket

Is that ok to be committed?
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2013-07-23 06:04:18 UTC 
I can't test it, but I guess go ahead and commit and we'll see if anyone on solaris yells.
Comment 5 Christoph Junghans (RETIRED) gentoo-dev 2013-07-24 03:21:41 UTC 
@@ -4,0 +5,3 @@
+  24 Jul 2013; Christoph Junghans <ottxor@gentoo.org> smpeg-0.4.4-r9.ebuild:
+  added prefix support (bug #475970)
+