Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 475216 - www-servers/lighttpd: please review prefix changes
Summary: www-servers/lighttpd: please review prefix changes
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Prefix
URL: http://redmine.lighttpd.net/issues/2447
Whiteboard:
Keywords: Inclusion, PATCH
Depends on:
Blocks: prefix-gx86
  Show dependency tree
 
Reported: 2013-06-29 13:37 UTC by Christoph Junghans (RETIRED)
Modified: 2016-03-23 02:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
handle plugins in the right way (lighttpd-darwin-bundle.patch,477 bytes, patch)
2013-06-29 13:37 UTC, Christoph Junghans (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans (RETIRED) gentoo-dev 2013-06-29 13:37:34 UTC
Created attachment 352238 [details, diff]
handle plugins in the right way

The patch only does a minor change. I had submitted it upstream a long time ago and it slipped under my radar.

@grobian: can you comment on the upstream tracker
Comment 1 Fabian Groffen gentoo-dev 2013-06-29 21:22:42 UTC
this is not going to work that way

We modified libtool in Gentoo Prefix to use the .bundle extension way back in the past, because at that time Apple documented that they suggested to use ".bundle" extension for modules.  They most likely removed all of that when they started working with bundle directories for "plugins" (the higher level application kind).

.bundle is cleaner than .so, simply because it's not a shared object, but a module, and definitely not ELF, while ELF makes no distinction between a module or a shared library.

We won't be able to convince the rest of the world though, it's legacy that resulted from a wrong decision in the past.
Comment 2 Fabian Groffen gentoo-dev 2013-07-02 08:47:41 UTC
From the patch we apply to libtool:

"
In Gentoo Prefix we go by Apple's convention to give modules the .bundle
extension.
http://developer.apple.com/documentation/DeveloperTools/Conceptual/             XcodeBuildSystem/500-Linking/bs_linking.html
"

(That link no longer exists...)

The web archived this link:

http://disanji.net/iOS_Doc/#documentation/DeveloperTools/Conceptual/XcodeBuildSystem/500-Linking/bs_linking.html

To quote from that document:

"
Bundle. Bundles are executable files that can be loaded at runtime by other products. Plug-ins are implemented using bundles. The term bundle in this context refers to the binary itself, not to a structured hierarchy. Bundles have the .bundle extension; for example, MyBundle.bundle.
"
Comment 3 Christoph Junghans (RETIRED) gentoo-dev 2013-07-13 17:57:00 UTC
I guess, we should merge that patch then, it is close to trivial anymore?

@wired/hwoarang: Are you ok with that?

Bside that patch the only changes needed are:
- ${D} -> ${ED}
- ${ROOT} -> ${EROOT}
- add ${EPREFIX} to --libdir option in src_configure
Comment 4 Christoph Junghans (RETIRED) gentoo-dev 2016-03-23 02:18:02 UTC
Re-submit later.