Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 474940 - app-arch/xz-utils: support multilib
Summary: app-arch/xz-utils: support multilib
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gx86-multilib 479620
  Show dependency tree
 
Reported: 2013-06-27 06:45 UTC by Pacho Ramos
Modified: 2013-08-07 22:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild diff (xz-multilib.patch,1.17 KB, patch)
2013-07-31 20:33 UTC, Alexis Ballier
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2013-06-27 06:45:37 UTC
Will be needed for "elfutils" (needed for glib-2). I can work on it if nobody else if able

Reproducible: Always
Comment 1 SpanKY gentoo-dev 2013-06-29 02:47:28 UTC
i think we need to sort out the /bin compilation question (that was left unanswered in bug 457134)

we should be able to have the nested compile check like $DEFAULT_ABI and only build the libs when $ABI is not that.  or maybe the eclass provides something for it already.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-06-29 08:07:12 UTC
  [[ ${ABI} == ${DEFAULT_ABI} ]]

is the current way. I will wrap that in the eclass anyway, since it will be easier to maintain, bug #473852.
Comment 3 SpanKY gentoo-dev 2013-07-02 16:20:07 UTC
(In reply to Michał Górny from comment #2)

hmm, is_final_abi from multilib.eclass already serves this purpose, albeit not in the most obvious way as it's intended (but not required) to also be used with `get_all_abis`.
Comment 4 Alexis Ballier gentoo-dev 2013-07-31 20:33:14 UTC
Created attachment 354766 [details, diff]
ebuild diff

proposed patch, please review.
Comment 5 Alexis Ballier gentoo-dev 2013-08-06 15:35:20 UTC
(In reply to Alexis Ballier from comment #4)
> Created attachment 354766 [details, diff] [details, diff]
> ebuild diff
> 
> proposed patch, please review.

will apply in a few days if i hear no comment
Comment 6 Doug Goldstein (RETIRED) gentoo-dev 2013-08-07 15:43:03 UTC
(In reply to Alexis Ballier from comment #5)
> (In reply to Alexis Ballier from comment #4)
> > Created attachment 354766 [details, diff] [details, diff] [details, diff]
> > ebuild diff
> > 
> > proposed patch, please review.
> 
> will apply in a few days if i hear no comment

Looks fine. Go ahead.
Comment 7 SpanKY gentoo-dev 2013-08-07 18:16:30 UTC
(In reply to Alexis Ballier from comment #4)

LGTM
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-07 22:40:09 UTC
Committed then as -r1.
Comment 9 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-07 22:40:22 UTC
(plus updated -9999)