$ grep -Ri avconv $ grep -Ri ffmpeg modules/gallery/helpers/movie.php -a3 /** * Extract a frame from a movie file. Valid movie_options are start_time (in seconds), * input_args (extra ffmpeg input args) and output_args (extra ffmpeg output args). Extra args * are added at the end of the list, so they can override any prior args. * * @param string $input_file -- * @param array $movie_options (optional) */ static function extract_frame($input_file, $output_file, $movie_options=null) { $ffmpeg = movie::find_ffmpeg(); if (empty($ffmpeg)) { throw new Exception("@todo MISSING_FFMPEG"); } list($width, $height, $mime_type, $extension, $duration) = movie::get_file_metadata($input_file); -- $input_args = isset($movie_options["input_args"]) ? $movie_options["input_args"] : ""; $output_args = isset($movie_options["output_args"]) ? $movie_options["output_args"] : ""; $cmd = escapeshellcmd($ffmpeg) . " $input_args -i " . escapeshellarg($input_file) . " -an $start_time_arg -an -r 1 -vframes 1" . " -s {$width}x{$height}" . " -y -f mjpeg $output_args " . escapeshellarg($output_file) . " 2>&1"; -- if (filesize($output_file) == 0 || $exec_return) { // Maybe the movie needs the "-threads 1" argument added // (see http://sourceforge.net/apps/trac/gallery/ticket/1924) $cmd = escapeshellcmd($ffmpeg) . " -threads 1 $input_args -i " . escapeshellarg($input_file) . " -an $start_time_arg -an -r 1 -vframes 1" . " -s {$width}x{$height}" . " -y -f mjpeg $output_args " . escapeshellarg($output_file) . " 2>&1"; -- P.S. bugtracker does not know about 'daniel.heule@gmail.com', seems metadata.xml is obsolete.
What's the fix?
call avconv if present and update the parameters fed to it in any case.
Upstream stopped development long time ago and I doubt this will be ever fixed :/ (I also wonder about the security of this package looking to the history of security bugs that were appearing at the time upstream care about :|)
Then what do we do with it?
I think maintainers have 2 options: 1. Make this hard depend on media-video/ffmpeg 2. CCing treecleaners and remove this if they think this package is no widely used any more as it won't receive any updates/fixes in the future
(In reply to Pacho Ramos from comment #5) > I think maintainers have 2 options: > 1. Make this hard depend on media-video/ffmpeg > 2. CCing treecleaners and remove this if they think this package is no > widely used any more as it won't receive any updates/fixes in the future it was a nice piece of software in its day and i feel bad to let it go. the package was maintainer needed and so i saved it, but i think its time for tree cleaning. pacho, how do i do that, just cc treecleaner?
Yeah, I will CC us just now, anyway that doesn't block anyone from going ahead and masking it for removal without waiting for treecleaners to have enough time for doing so ;)
removed
