Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 472776 - media-video/tovid-0.34_p20120123: Deprecated imports of PIL modules
Summary: media-video/tovid-0.34_p20120123: Deprecated imports of PIL modules
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 471488
  Show dependency tree
 
Reported: 2013-06-09 18:54 UTC by Mike Gilbert
Modified: 2013-09-09 04:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2013-06-09 18:54:20 UTC
See tracker bug 471488 for details.

snippets/render/anim.py:import Image # for im.size, etc..
snippets/render/slider.py:import Image
snippets/render/still.py:import Image
snippets/fontchoices-demo:import ImageTk
Comment 1 Martin von Gagern 2013-06-12 18:59:28 UTC
Looks to me as if these snippets have no effect on the set of installed files:

* “qlist -e tovid | xargs grep 'import.*Image'” gives no match, so those imports aren't part of the textual content of installed files
* “grep -r snippets .” in the WORKDIR of the ebuild gives only a single unrelated match, so that directory is not involved in the build process
* The ebuild does not mention “snippets” either

So it seems that there is no urgent need to update any files. Instead, the dependency on imaging could be altered to virtual/python-imaging, or perhaps even dropped completely. Unless these snippets SHOULD get installed, and are only omitted due to some deficiency of the ebuild.

Looking at CVS, it seems that this dependency was introduced by the version bump to tovid-0.29 (07 Nov 2006). The ChangeLog does not give any indication as to why that dep should be neccessary. Instead it references bug 101346 which looks completely unrelated. The correct reference should be bug 154266, and indeed bug 154266 comment 2 talks about this imaging dependency. Not sure whether there is any reason to actually have that. I can see none.
Comment 2 Mike Gilbert gentoo-dev 2013-06-12 19:36:30 UTC
Dropping the (unnecessary) dependency on dev-python/imaging would be an acceptable solution.
Comment 3 Mike Gilbert gentoo-dev 2013-09-09 04:43:19 UTC
+  09 Sep 2013; Mike Gilbert <floppym@gentoo.org> tovid-0.34.ebuild,
+  tovid-0.34_p20120123.ebuild:
+  Drop dependency on dev-python/imaging, see bug 472776.