Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 471974 - =media-sound/kid3-3.0 - version bump
Summary: =media-sound/kid3-3.0 - version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo KDE team
URL: https://sourceforge.net/p/kid3/bugs/8...
Whiteboard:
Keywords:
: 489184 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-06-01 04:21 UTC by BT
Modified: 2016-08-11 11:14 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description BT 2013-06-01 04:21:56 UTC
kid3 2.3 was released on 2013/03/10.
Comment 1 Johannes Huber (RETIRED) gentoo-dev 2013-06-01 12:41:50 UTC
* Release 2.3
+ Automatic batch import for multiple directories.
+ Import catalog number and release country from Discogs and MusicBrainz.
+ Quick access tags are configurable for tag 2.
+ Setting for default file name to save cover art.
+ Select all in directory.
+ Apply text encoding.
+ Support Qt 5.0.

CMakeList.txt:
> string(REGEX MATCH "^(.*[Qq]t5.*).bin.qmake.*" _qt5Dir ${QT_QMAKE_EXECUTABLE}")
> if (_qt5Dir)
>  set(_qt5Dir ${CMAKE_MATCH_1})
> endif (_qt5Dir)

Needs build system patch...
Comment 2 Johannes Huber (RETIRED) gentoo-dev 2013-10-23 18:54:11 UTC
*** Bug 489184 has been marked as a duplicate of this bug. ***
Comment 3 Johannes Huber (RETIRED) gentoo-dev 2013-10-23 18:55:27 UTC
Same build system magic of qt5 in 3.0. Needs still patching.
Comment 4 Coacher 2013-11-02 03:31:49 UTC
kid3-3.0.1 was released ([0]) with the following changelog:

"This is a bug fix release for 3.0. It fixes the incorrect configuration conversion and toolbar configuration in the KDE version, the filename format configuration, bugs in the fingerprint import and several build issues for different Linux distributions."

Could you please test whether this release resolve those build issues?

[0]:http://kid3.sourceforge.net/#history
Comment 5 Johannes Huber (RETIRED) gentoo-dev 2013-11-03 12:15:26 UTC
3.0.1 has the same build system magic.
Comment 6 Coacher 2013-11-03 12:28:26 UTC
(In reply to Johannes Huber from comment #5)
> 3.0.1 has the same build system magic.

Could you please give some additional details rather than just saying that patch needed? This way I will be able to create a bugreport upstream so they can resolve this problem.
Comment 7 Johannes Huber (RETIRED) gentoo-dev 2013-11-03 12:37:04 UTC
(In reply to Coacher from comment #6)
> Could you please give some additional details rather than just saying that
> patch needed? This way I will be able to create a bugreport upstream so they
> can resolve this problem.

See comment 1 for details, it has hack to detect Qt5. Which let us NOT control whether kid3 is build against Qt4 or Qt5. cmake provides regular find modules to detect the both Qt major versions. So a build option is needed and the usage of the correct find modules.

Cheers
Comment 8 Coacher 2013-11-21 09:52:44 UTC
Upstream bugreport: https://sourceforge.net/p/kid3/bugs/84/
Comment 9 Coacher 2013-11-21 10:12:26 UTC
(In reply to Johannes Huber from comment #7)
Please see the reply from the project author: https://sourceforge.net/p/kid3/bugs/84/#6989
Comment 10 Johannes Huber (RETIRED) gentoo-dev 2013-11-24 17:38:41 UTC
Thanks all. 3.0.1 bumped. This is fixed in cvs Sync in some hours to get the changes. Note: Qt5 build option is disabled as not all required deps in qt overlay available. 

+
+  24 Nov 2013; Johannes Huber <johu@gentoo.org>
+  +files/kid3-3.0.1-qt5-automagic.patch, +files/kid3-3.0.1-rpath.patch,
+  +kid3-3.0.1.ebuild:
+  Version bump wrt bug #471974.
+
Comment 11 Nikos Chantziaras 2013-11-24 20:58:33 UTC
Doesn't emerge:

CMake Error at po/CMakeLists.txt:25 (add_custom_command):
  add_custom_command Wrong syntax.  A TARGET or OUTPUT must be specified.
Comment 12 Johannes Huber (RETIRED) gentoo-dev 2013-11-24 21:45:40 UTC
(In reply to Nikos Chantziaras from comment #11)
> Doesn't emerge:
> 
> CMake Error at po/CMakeLists.txt:25 (add_custom_command):
>   add_custom_command Wrong syntax.  A TARGET or OUTPUT must be specified.

Please open a new bug about this issue.