Bug 469026 – net-libs/libiscsi should drop -Werror

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2013-05-08 11:07:25 UTC]

This package should drop -Werror enabled by the buildsystem.

[Comment 1 eroen 2013-05-23 16:15:43 UTC]

Created attachment 349001 [details]
build.log with gcc-4.8.0

This breaks building net-libs/libiscsi-1.9.0 with gcc-4.8.0. Build log attached.

[Comment 2 eroen 2013-05-23 16:18:28 UTC]

Created attachment 349003 [details]
libiscsi-1.9.0-werror.patch

Patch to disable -Werror. 

Ebuild patch:
--- a/net-libs/libiscsi/libiscsi-1.9.0.ebuild
+++ b/net-libs/libiscsi/libiscsi-1.9.0.ebuild
@@ -5,7 +5,7 @@
 EAPI=5
 
 AUTOTOOLS_AUTORECONF="1"
-inherit autotools-utils
+inherit eutils autotools-utils
 
 if [[ ${PV} = *9999* ]]; then
        inherit git-2
@@ -26,3 +26,8 @@ IUSE=""
 
 DEPEND=""
 RDEPEND="${DEPEND}"
+
+src_prepare() {
+       epatch "${FILESDIR}"/${P}-werror.patch
+       autotools-utils_src_prepare
+}

[Comment 3 Richard Yao (RETIRED) 2013-05-29 17:50:08 UTC]

ago, I have been somewhat busy lately, but I will look into this soon. Thanks for the report.

eooen, thanks for the patch. I will try it out soon. :)

[Comment 4 Doug Goldstein (RETIRED) 2013-06-05 19:46:00 UTC]

I fixed this in a way that upstream will hopefully find acceptable and committed this as -r1 and submitted the patch upstream.