Bug 466714 – www-plugins/nspluginwrapper: please change emul-linux dep to any-of dep

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Michał Górny 2013-04-21 19:10:24 UTC]

nspluginwrapper ebuild has RDEP:

  app-emulation/emul-linux-x86-xlibs

Please replace it with:

  || (
    (
      x11-libs/libXfoo[abi_x86_32]
      x11-libs/libXbar[abi_x86_32]
      ...
    )
    app-emulation/emul-linux-x86-xlibs
  )

to support both emul-linux and split multilib packages. Thanks in advance.

[Comment 1 Lars Wendler (Polynomial-C) (RETIRED) 2014-08-31 09:21:05 UTC]

Created attachment 383996 [details, diff]
nspluginwrapper-1.4.4-r4.ebuild.diff

Possible fix which also bumps EAPI to version 5.

[Comment 2 Michał Górny 2014-09-02 13:14:50 UTC]

1. Please use [-abi_x86_32(-)] on emul-linux-x86 deps,

2. Please use multilib-dep-fixor [1] to set versions of deps.

As a side note, you probably may try to get the '-m32' flag using get_ABI_CFLAGS for x86. However, that's just a minor remark and I don't know how well that will work.

[1]:https://bitbucket.org/mgorny/multilib-dep-fixor

[Comment 3 Lars Wendler (Polynomial-C) (RETIRED) 2014-09-07 15:37:05 UTC]

Created attachment 384350 [details, diff]
nspluginwrapper-1.4.4-r4.ebuild.diff

(In reply to Michał Górny from comment #2)
> 1. Please use [-abi_x86_32(-)] on emul-linux-x86 deps,

Done.

> 2. Please use multilib-dep-fixor [1] to set versions of deps.

# multilib-dep-fixor.py 
Traceback (most recent call last):
  File "/usr/local/bin/multilib-dep-fixor.py", line 5, in <module>
    from gentoopm import get_package_manager
ImportError: No module named gentoopm

> As a side note, you probably may try to get the '-m32' flag using
> get_ABI_CFLAGS for x86. However, that's just a minor remark and I don't know
> how well that will work.
> 
> [1]:https://bitbucket.org/mgorny/multilib-dep-fixor

Dunno if this is the correct approach here since the -m32 flag gets set for 32bit LDFLAGS (LDFLAGS_32), not CFLAGS.

[Comment 4 Michał Górny 2014-09-07 16:15:52 UTC]

(In reply to Lars Wendler (Polynomial-C) from comment #3)
> > 2. Please use multilib-dep-fixor [1] to set versions of deps.
> 
> # multilib-dep-fixor.py 
> Traceback (most recent call last):
>   File "/usr/local/bin/multilib-dep-fixor.py", line 5, in <module>
>     from gentoopm import get_package_manager
> ImportError: No module named gentoopm

Suggested solution: emerge -1v gentoopm :).

> > As a side note, you probably may try to get the '-m32' flag using
> > get_ABI_CFLAGS for x86. However, that's just a minor remark and I don't know
> > how well that will work.
> > 
> > [1]:https://bitbucket.org/mgorny/multilib-dep-fixor
> 
> Dunno if this is the correct approach here since the -m32 flag gets set for
> 32bit LDFLAGS (LDFLAGS_32), not CFLAGS.

Yes, it is. LDFLAGS are still compiler-formed flags, and multilib.eclass uses get_ABI_CFLAGS both for compiling and linking.

[Comment 5 Lars Wendler (Polynomial-C) (RETIRED) 2014-09-07 17:03:08 UTC]

Created attachment 384352 [details, diff]
nspluginwrapper-1.4.4-r4.ebuild.diff

And here comes the patch with correct dependency versions.

[Comment 6 Lars Wendler (Polynomial-C) (RETIRED) 2014-09-07 20:27:31 UTC]

Created attachment 384376 [details, diff]
nspluginwrapper-1.4.4-r4.ebuild.diff

Now with all suggestions from mgorny included. Please review.

[Comment 7 Michał Górny 2014-09-07 20:51:00 UTC]

Great work, thanks.

[Comment 8 Lars Wendler (Polynomial-C) (RETIRED) 2015-02-16 18:02:40 UTC]

This has already been fixed in October 2014...