Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 466190 - =gnome-extra/nm-applet with media-libs/libpng-1.6 - Icon nm-signal-75 missing: (0) Fatal error reading PNG image file: Decompression error in IDAT
Summary: =gnome-extra/nm-applet with media-libs/libpng-1.6 - Icon nm-signal-75 missing...
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nirbheek Chauhan (RETIRED)
Depends on:
Blocks: 468386
  Show dependency tree
Reported: 2013-04-17 05:19 UTC by Tom Wijsman (TomWij) (RETIRED)
Modified: 2013-09-12 07:51 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---

nm-signal-75.png (nm-signal-75.png,470 bytes, image/png)
2013-04-17 07:23 UTC, Samuli Suominen (RETIRED)
nm-applet- (nm-applet-,543 bytes, patch)
2013-04-17 18:09 UTC, Samuli Suominen (RETIRED)
Details | Diff
List of broken PNGs (broken_files.txt,6.84 KB, text/plain)
2013-04-20 12:40 UTC, Tobias Klausmann (RETIRED)
parallel PNG checker (,1.60 KB, text/x-python)
2013-04-20 13:08 UTC, Tobias Klausmann (RETIRED)
List of distfiles + packages containing/using broken PNGs (distfiles_with_broken_pngs.txt,119.12 KB, text/plain)
2013-04-21 13:53 UTC, Tobias Klausmann (RETIRED)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-17 05:19:06 UTC
NetworkManager applet shows a red filled circle with a white dash in it, my TTY is getting spammed with the message in the bug summary; a quick google for that yields this has to do with the libpng 1.6 upgrade. If needed, feel free to reassign to the libpng maintainers since this then may be a regression for them.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2013-04-17 07:21:20 UTC
I've googled the mailing list thread and saw this reply from Mark Adler (zlib upstream) in it:

"Those files are in fact broken, in that the zlib header says that a 512-byte window is ok, but the maximum distance found in all of them is 1419.  That would require at least a 2048-byte window.

For zlib to detect this, it has to be compiled with INFLATE_STRICT defined.  The default compilation of zlib does not check for strict compliance of the compressed data to the specified window size.

zlib will report an error if it has to look further back than the sliding window it has retained, but if it has the data that far back available, it will use it.  These files are one example of that case, where there would very likely be enough output space provided to decompress in a single step (all are less than 2K decompressed), so that a sliding window is never even created.  In that case, all of the output is available, and zlib can correctly decompress the input, even if windowBits == 9 is specified.

As I recall, INFLATE_STRICT was added specifically at the request of the PNG community.


I'm puzzled what "Those files are in fact broken" in facts means for us. In the same thread Glenn mentions latest pngcrush "fixing" the files. I'll ask them by mail if this is something that is going to be fixed in libpng or not, or if we should "fix" the files.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2013-04-17 07:23:47 UTC
Created attachment 345742 [details]

icons/22/nm-signal-75.png from network-manager-applet- tarball
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2013-04-17 12:06:57 UTC
This is the reply from Glenn I got,

"You can fix them with the current version of pngcrush, built with libpng-1.5.15,
or for that matter most any image editor/converter built with libpng-1.5.15 or
earlier will write them with the proper zlib headers.  Reverting to libpng-1.5.15
works because this actually allocates a 32k window regardless of what CMF asks for."

So it seems this will not be fixed in libpng and the files are really broken and it's an bug in nm-applet because of it.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2013-04-17 18:09:30 UTC
Created attachment 345816 [details, diff]

Upgrade pngcrush to 1.7.57 with USE="-system-libs" and you can for example `pngcrush -fix -force nm-signal-00.png`

I've done that for you and rolled them into .tar.xz:
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2013-04-17 18:10:03 UTC
The ebuild patch is untested, but I'm sure you will notice :-)
Comment 6 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-04-17 18:53:15 UTC
Okay, will try this tomorrow and let you know.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2013-04-18 11:04:24 UTC
Reported to upstream:
Comment 9 Tobias Klausmann (RETIRED) gentoo-dev 2013-04-20 12:40:30 UTC
Created attachment 346084 [details]
List of broken PNGs

I'll attach a list of broken PNGs on my system. I've already removed the obviously-on-our-problem ones (e.g. /home/**). Not all of the rest re claimed by packages. 

I'll also attach a list of packages-with-files for the claimed files as soon as I have it.
Comment 10 Tobias Klausmann (RETIRED) gentoo-dev 2013-04-20 12:49:50 UTC
Comment on attachment 346084 [details]
List of broken PNGs

This file list is incorrect since convert sees invalid ICC profiles as "broken". I'll remake the list.
Comment 11 Tobias Klausmann (RETIRED) gentoo-dev 2013-04-20 13:08:31 UTC
Created attachment 346088 [details]
parallel PNG checker

New and improved parallel checker attached.

Output for my system:

# locate png |grep \\.png$ | ~klausman/
Checked 54637 files in 165.99 seconds, 329.15 files/s.
4 files need fixing.

Will file an smplayer bug blocking this one.
Comment 12 Tobias Klausmann (RETIRED) gentoo-dev 2013-04-21 13:53:11 UTC
Created attachment 346192 [details]
List of distfiles + packages containing/using broken PNGs

I've made a copy of a distfile mirror and checked all distfiles if they contain broken PNGs (only broken in the sense of this bug). Attached is a list of them. Since we're talking about 232 distfiles in almost 100 packages, I'd very much prefer filing the corresponding bugs autmatically, not by hand. 

Unfortunately, I have no experience scripting bug submission and I'm out of time for today. Feel free to pick up where I left.
Comment 13 Tobias Klausmann (RETIRED) gentoo-dev 2013-04-21 13:55:25 UTC
Addendum: the KDE packages are a bit messy in that file. I think we should file a master bug with the KDE team since figuring out what is used by which package is tricky.
Comment 14 Samuli Suominen (RETIRED) gentoo-dev 2013-05-03 10:07:42 UTC
+  03 May 2013; Samuli Suominen <> nm-applet-,
+  nm-applet-
+  Fix nm-signal-*.png icons with media-gfx/pngcrush built against libpng15 for
+  -fix -force to correct IDAT lenght wrt #466190

Futher discussion happens in bug 468386 if needed, let's stop bugspamming the nm-applet maintainer now ;)
Comment 15 Evgeny Bobkin 2013-09-12 07:51:12 UTC
(In reply to Samuli Suominen from comment #14)
> +  03 May 2013; Samuli Suominen <>
> nm-applet-,
> +  nm-applet-
> +  Fix nm-signal-*.png icons with media-gfx/pngcrush built against libpng15
> for
> +  -fix -force to correct IDAT lenght wrt #466190
> Futher discussion happens in bug 468386 if needed, let's stop bugspamming
> the nm-applet maintainer now ;)

great work