Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 465100 - net-misc/networkmanager-0.9.8.0 - wrong bash-completion directory
Summary: net-misc/networkmanager-0.9.8.0 - wrong bash-completion directory
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nirbheek Chauhan (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: gnome-3.8
  Show dependency tree
 
Reported: 2013-04-08 14:00 UTC by poncho
Modified: 2013-05-18 15:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (completions.patch,613 bytes, patch)
2013-04-08 14:00 UTC, poncho
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description poncho 2013-04-08 14:00:07 UTC
Created attachment 344834 [details, diff]
ebuild patch

The bash-completion is installed into /usr/share/bash-completion/completions but should be in /usr/share/bash-completion.

eselect bashcomp doesn't work with /usr/share/bash-completion/completions
Comment 1 poncho 2013-04-08 14:00:51 UTC
Comment on attachment 344834 [details, diff]
ebuild patch

>diff --git a/net-misc/networkmanager/networkmanager-0.9.8.0.ebuild b/net-misc/networkmanager/networkmanager-0.9.8.0.ebuild
>index 584aac9..e0a35ba 100644
>--- a/net-misc/networkmanager/networkmanager-0.9.8.0.ebuild
>+++ b/net-misc/networkmanager/networkmanager-0.9.8.0.ebuild
>@@ -116,6 +116,10 @@ src_prepare() {
> 	# Force use of /run, avoid eautoreconf
> 	sed -e 's:$localstatedir/run/:/run/:' -i configure || die
> 
>+	# Fix completiondir, avoid eautoreconf
>+	sed -i 's|^completiondir =.*|completiondir = $(datadir)/bash-completion|' \
>+		cli/completion/Makefile.in || die "sed completiondir failed"
>+
> 	default
> }
>
Comment 2 Alexander Tsoy 2013-04-12 17:04:50 UTC
/usr/share/bash-completion/completions is a default location for >=bash-completion-2.0. So it's better to patch build system to get completiondir from pkg-config and block <app-shells/bash-completion-1.3-r1 in ebuild.

See also: bug 395091
Comment 3 Pacho Ramos gentoo-dev 2013-05-18 15:56:45 UTC
+  18 May 2013; Pacho Ramos <pacho@gentoo.org> networkmanager-0.9.8.0.ebuild:
+  Add some fixes to the ebuild and fix bash-completion locations (#465100 by
+  poncho)
+